Review locale module's simple tests

+    $langcode = $this->randomName(6, 'si-');
+    // The English name for the language.
+    $name = $this->randomName(16);

Recently webchick's asking for all inline comments to have a line break above, not sure how set in stone that is yet though.

+
+
+    // Ensure 'edit' link works.

extra line break. There's a couple of these.

     // It's presumed that this is the only result. Given the random name, it's
     // reasonable.

Comment is already there in the test but it's a bit clunky, but how about this instead?

+    // Assume this is the only result, given the random name.

+    // The domain prefix. Not tested yet.
+    $prefix = strtolower(str_replace('si-', '', $langcode));

Should this be a @TODO?

 // assertText seems to remove the input field where $name always could be

Not sure if we do it for methods, but usually we add () after function names in comments to help them stand out.

// The importation

Just 'import' maybe? Looks like both might be technically correct and it comes down to usage.

     // The importation should have create 7 strings.

Not touched by the patch, but should be 'created' here.

+    // There are two 'Export' buttons on this page, but it somehow works.  It'd
+    // be better if we could use the submit button id like documented but it
+    // doesn't work.

Do these buttons do exactly the same thing? Could we make them "Export foo" and "Export bar"? ~(might be kitten killing in this issue though). Maybe add a @TODO for the submit button id?

Looks like it adds a lot of coverage, and does some really nice cleanup of the existing test as well. Nice! Feel guilty marking as CNW :(

Committed to CVS HEAD. Thanks!

D7 patch in #296584: Incorrect t()ing of menu item title in example fails at one of the new tests.

Strange thing is: the (single-line) patch only changes menu.api.php (documentation) and is trivial. I couldn't find more information about which specific assertion failed so I don't have a clue where to start looking, but I don't see a reason why the patch would fail.

I was hoping someone involved in adding these tests can help me out here.

I hit this error: no write access to create the modules/locale/tests/translations directory.

So, indeed, rather than dynamically generating a translation file, we need to have one present for testing purposes.

To avoid unintended results - e.g., regular translations files being imported along with test ones - we need to set an invalid language code for some test files. This patch uses the invalid code xx. In some cases we will want a second language code (e.g., to test an enabled vs. a disabled language). We can use an extended code for this: xx-yy.

For consistency, it makes sense to use the same testing language codes in the various places where we need them, rather than retaining the previous randomly generated ones.

Tested locally. I'll wait for the testbot to confirm this before marking RTBC.

Fix an error in the path to the added file.

I got a failure before applying this patch. Now it works fine. Committed to HEAD. Thanks!

I'm going to try switching testing bot on again... wish me luck. ;P