Remove 'exclude from $content' display setting

It's easy for the core field code to allow for this, but quite a bit more complicated for an external module to provide. At least thinking through what CCK would have to do to provide this looks a lot more complicated to me. We have precedents for items that core handles mostly as a convenience to other modules (like some hook_devel stuff and various features that are not used by core at all) so I don't think that's a bad thing.

But conceptually I think core needs a way to reliably render individual fields as well as the whole node content array. Or maybe things like filters need to be run at the field level instead of the node level. Either way, we may need to do some re-thinking of the core processing.

hook_node_alter() seems to be a 'by design' to me (regardless of whether we are talking about the old hook_node_alter() or what I think replaces it now, hook_preprocess_node()). It's just by definition that these hooks act on the rendered node as handed out by node module(s), the theme is always able to add more stuff later on, so modules should not rely on it for doing critical operations. I think that modules should even use hook_pager_alter() instead if catching absolutely everything is what they want.

For 'exclude' implementation, can't this just be a dummy formatter which doesn't do anything? :)

(Btw, can't the 'hidden' display type be used for that?)

Oh, exclude checkbox, you served us well in D6. Now its time for you to die. +1

I do love so very much patches with lots and lots of - signs.

Yeah, it does feel good to rm dodgy code.

+++ modules/field/field.default.inc	18 Jun 2009 23:59:53 -0000
@@ -194,60 +195,13 @@
     // See 'preprocess' op and theme_content_field_wrapper().
     $wrapper = $info + array(
       'field' => $element,
-      '#weight' => $instance['weight'],
-      '#post_render' => array('field_wrapper_post_render'),
-      '#context' => $context,
     );
 
-    $addition = array($field['field_name'] => $wrapper);
+    $addition = array($field['field_name'] => $element);
   }
   return $addition;
 }

...

    // The wrapper lets us get the themed output for the whole field
    // to populate the $FIELD_NAME_rendered variable for templates,
    // and hide it from the $content variable if needed.
    // See 'preprocess' op and theme_content_field_wrapper().
    $wrapper = $info + array(
      'field' => $element,
      '#weight' => $instance['weight'],
      '#post_render' => array('field_wrapper_post_render'),
      '#context' => $context,
    );

    $addition = array($field['field_name'] => $wrapper);

It seems the entire code for $wrapper can go.

Code like that makes me think of #theme_wrapper which is a new render property - see drupal_render() docs.

It still feels good deleting all this code. I will reopen this patch whenever I am feeling down.

Committed to CVS HEAD. Yay!

'preprocess' is no longer a valid $op for _field_invoke(). I feel confident RTBC'ing my own patch for this. :-)

Bold move, Barry, but committed to CVS HEAD. ;-)

Was it really necessary to remove exclude especially when there is absolutely no D7 module that provides this functionality? There are use cases where the exclude field saves alot of headache. Now i am stuck trying to figure out another option & I dont even know where to start.