Cleanup cruft from removal of hook_user($op) [#358021]

There's a couple of functions in user.module _user_edit_validate() and _user_edit_submit() that don't really need to be functions. They should be pulled up into user_user_validate() and user_user_submit() respectively.

Comment	File	Size	Author
	user_op_cleanup.patch	3.99 KB	drewish

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

RobLoach

he/him

CreditAttribution: RobLoach commented 13 January 2009 at 06:21

Status:

Needs review

» Reviewed & tested by the community

Comment #2

drewish CreditAttribution: drewish commented 13 January 2009 at 06:22

did a grep to see if either function was used elsewhere in core and couldn't find any.

Comment #3

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 13 January 2009 at 06:27

Status:

Reviewed & tested by the community

» Fixed

Thanks, committed to HEAD.

The only reason I could think for these to be separated is if they were intended to be called from other modules that weren't doing the form process. But if that's the case, why do they still take an $edit array, and why are they prefixed with an underscore?