Problem/Motivation

The Rabbit Hole settings details element is shown on the vocabulary overview page. Maybe it's just an opinion, but I feel like it doesn't belong there. I'm also pretty sure it didn't appear there before updating my site to Drupal 11.3.2.

Steps to reproduce

Visit a taxonomy vocabulary list page.

Proposed resolution

Exclude 'overview' entity operations.

CommentFileSizeAuthor
#15 rabbit_hole-MR95-3567965-15.patch719 bytesisampo

Issue fork rabbit_hole-3567965

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dieterholvoet created an issue. See original summary.

dieterholvoet opened merge request !95

dieterholvoet’s picture

dieterholvoet commented
Status: Active » Needs review
kazuko.murata’s picture

kazuko.murata commented
Related issues: +#3564792: Changes to the order of taxonomy elements are not saved.

It works fine on Drupal Core 11.3.2 and Rabit Hole 8.x-1.0.

johnatas’s picture

johnatas commented

Hello,
I can reproduce the issue with Drupal 11.3.2 and Rabbit Hole 2.0.0-beta1.

This issue appears to come from this change: Drupal\taxonomy\Form\OverviewTerms now extends Drupal\Core\Entity\EntityForm introduced in Drupal 11.3.0.

The fix proposed in MR !95 correctly fixes the problem.

Thanks,

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: dieterholvoet » Unassigned
Priority: Normal » Critical
Status: Needs review » Reviewed & tested by the community

Confirming this issue and setting priority to major, because it breaks the Taxonomy overview page saving functionality entirely, as reported in #3564792: Changes to the order of taxonomy elements are not saved.

Maybe you could ping a mainainer @dieterholvoet?

ronchica’s picture

ronchica commented

This fix also needs to be applied to the 8.x branch. It is a major issue as we cannot save the taxonomy term pages without using the patch from #3564792.

japerry made their first commit to this issue’s fork.

japerry opened merge request !102

  • japerry committed 56a8ee7c on 8.x-1.x 
    fix: #3567965 Rabbit Hole settings are shown on vocabulary overview form
japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Confirmed against 1.x and 2.x. since this is critical, and no new tests failed with 8.x-1.x, both are merged!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks @japerry, would you mind tagging a release with this critical fix? Seems all Drupal ^11.2 projects are affected

isampo’s picture

isampo commented
StatusFileSize
new rabbit_hole-MR95-3567965-15.patch719 bytes

While waiting for the new release, here is the change from MR95 as a static patch for 2.0.0-beta1.

japerry’s picture

japerry
Location KOMK
commented

New releases made!

acbramley’s picture

acbramley commented

+1 to a new release with a critical fix (plus the 8.4 deprecation fixes!)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thank you very much @japerry!! :)
That was helpful.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.