Problem/Motivation

Currently the latest version of "sabberworm/php-css-parser" is required to ^8.6 with an additional patch. But recently it is updated to ^9.0 and the required patch has been updated to a better clean of the package.

Proposed resolution

To update the composer of this module to ^9.0 and remove the patch.
Note: https://github.com/MyIntervals/PHP-CSS-Parser/pull/797 -> Merged and created 9.0 for package "sabberworm/php-css-parser".

Remaining tasks

Not sure of any probable impact. So needs to be tested.

Issue fork ui_styles-3544352

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

arnabcse2013 created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper

Hi,

Thanks a lot for bringing that to attention.

I was not aware of the new sabberworm release. If no more need the patch, it will be very nice!

I planned synchronised releases in the UI Suite ecosystem, so I will test next time.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Title: Request to update "sabberworm/php-css-parser" » Update "sabberworm/php-css-parser"
Category: Support request » Task
arnabcse2013’s picture

arnabcse2013
Location Bangalore
commented

Thanks @grimreaper for this task.

Will wait for the new release :)

arnabcse2013’s picture

arnabcse2013
Location Bangalore
commented

@grimreaper Tomorrow I will raise a MR for the fix.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned

Thanks!

You can assign it to you if you want and un-assign when ready.

arnabcse2013’s picture

arnabcse2013
Location Bangalore
commented
Assigned: Unassigned » arnabcse2013

arnabcse2013 opened merge request !89

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: arnabcse2013 » grimreaper
Status: Active » Needs work
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

This issue allowed me to realize that there is a miss in the logic of gathering CSS files. It is forgetting dependencies. So since library reorganisation in ui_suite_bootstrap, it does not work because the framework css is from a sub library.

Will fix that too.

arnabcse2013’s picture

arnabcse2013
Location Bangalore
commented

@grimreaper Yeah.. Actually I was working to fix that too.

Infact, I am ignoring one portion of condition for phpstan to pass as that section is always returning true from phpstan.

So probably it will be little big fix, but tomorrow I will work on that as well (If you say so).

Let me know.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Don't worry this will be merged today :)

I have the fix for dependencies.

I was testing, back to sabberworm 8.6 without the patch to reproduce the problem I had that needed the patch. Impossible to reproduce.

So I will test with version 9.

arnabcse2013’s picture

arnabcse2013
Location Bangalore
commented

Perfect, :)

Thanks @grimreaper.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs work » Needs review

Hi again,

I pushed the fix. Also found a deprecation about views plugin annotation when executing tests locally.

I also put a review comment on my own change, an idea I realized after pushing.

If you can, please test and share your opinion.

After lunch break going to merge and release. I will squash your commits and only keep the views plugin change in a dedicated commit.

arnabcse2013’s picture

arnabcse2013
Location Bangalore
commented

Sure :)

Will have a look.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Can you please give a new look :)

arnabcse2013’s picture

arnabcse2013
Location Bangalore
commented

Checking.

arnabcse2013’s picture

arnabcse2013
Location Bangalore
commented

Hi @grimreaper,

Lets wait for one more day. I will do a fresh install today with the updated version and changes.

Will update by tomorrow morning, if thats okay for you.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Ok,

preparing the new squashed commits.

arnabcse2013’s picture

arnabcse2013
Location Bangalore
commented

@grimreaper Tested the changes for this MR and is applied without errors. You can change the status.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Reviewed & tested by the community

Thanks! I will try to merge and release today. Unfortunately affected to other subject.

arnabcse2013’s picture

arnabcse2013
Location Bangalore
commented

@grimreaper No worries !! Take your time, at least the MR is ready :)

  • grimreaper committed 42df8f1e on 8.x-1.x 
    [#3544352] chore: Use PHP Attribute for Views plugin.

By: grimreaper

  • grimreaper committed 6e0ee5be on 8.x-1.x 
    [#3544352] fix: library parsing not handling library dependencies.

By:...

  • grimreaper committed 349b9894 on 8.x-1.x 
    [#3544352] feat: Update "sabberworm/php-css-parser".

By: arnabcse2013...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.