Fix ToolkitGdTest for PHP 8.5

So, my idea was to recreate the file itself (maybe it has encoding issues), but that didn't work ...

Seems like rotation is affected either by our code or by how PHP8.5 handles it, as all rotate to 5 degrees tests are broken (file format is not relevant, it happens for all of them)

See https://git.drupalcode.org/issue/drupal-3540531/-/jobs/6225263#L2188

The other part is AVIF, I assume Docker image does not have AVIF support at all (or it's broken in PHP itself)

So, it seems that the default interpolation algorithm has been changed, see https://github.com/php/php-src/pull/17375/files#diff-a6d1ba8e66261eacec5...

That probably means that we need to adjust test to that

This is critical to support PHP 8.5.

So, the GD issue with rotate was indeed related to the default interpolation method change (should core now keep the BC and set it explicitly?)

The AVIF issues is mystery, as it fails on loading the image rather than processing. Is AVIF part of the docker image?

And due to new deprecations (PDO constants) most of the tests are red

I think PHP has broken AVIF detection by introducing HEIF/HEIC support here https://github.com/php/php-src/commit/dfac2da7fba930570fcda99205cfcf53db...

The problem is that HEIF image can ... pretend not not be HEIF, and ... be an AVIF

See https://github.com/nokiatech/heif/issues/74 for details

Our test image is like example C034.heic:

0x0000001C  // 28-bytes: size of 'ftyp' box.
'ftyp'      // boxtype
'mif1'      // major_brand
0x00000000  // minor_version
'mif1'      // compatible_brands[0]
'avid'      // compatible_brands[1]
'miaf'      // compatible_brands[2]

so it has mif1 and avif, but no hei* ... but PHP detects mif1 first and decides that the file is a HEIF image, which it's not true in this case

so, it does not support HEIF for processing, only for getting the image dimensions - and the code to do that is the same as avif:

		case IMAGE_FILETYPE_AVIF:
			result = php_handle_avif(stream);
			break;
		case IMAGE_FILETYPE_HEIF:
			if (!php_stream_rewind(stream)) {
				result = php_handle_avif(stream);
			}
			break;

and the reason for that is (I believe): both standards are basically use the same container format ... technically AVIF is an AV1 encoded image in HEIF container, while HEIC is an HEVC encoded image in HEIF container. Very confusing actually :D

AVIF images misdetected as HEIF after introducing HEIF support in getimagesize() was fixed upstream so in PHP 8.5RC4 we should not longer have that part to be solved.

What remains is the different default interpolation used in PHP 8.5 vs earlier versions.

This test is one of the longest running kernel tests, I think it would make sense to split it in an abstract base class and one concrete test class per image type (gif, png, webp, etc.).
It should not be that hard, will try to look into it.

IMHO

imagesetinterpolation($toolkit->getImage(), IMG_NEAREST_NEIGHBOUR);

should be placed in the toolkit code, conditionally on the PHP version, not in the test. Otherwise we'd be testing something that does not match the normal runtime behavior.

Or, we need to have different reference values to check against (again, PHP version-dependent).

Setting to NR for comments.

#29 - thanks @andypost, AVIF now looks OK in latest tests.

#28 - In the end I think we should be testing conditionally on PHP version, without changing the default interpolation algo. Latest commit does that.

All the new Kernel tests (one per image type) are green on PHP 8.5 now.

Out of curiosity, I checked out the rotated image derivatives from the CI runs, and they're actually quite different in PHP 8.4 and 8.5 (obviously, on the pixel level: you need to zoom in the image quite a lot to see a human perceivable difference). Attaching here.

This is an area where local testing may yield different results, as PHP with the embedded GD library (that Drupal GitLabCI uses) has code quite different from PHP that links the library separately, as #2921123: Adjust Rectangle class to calculate rotated image dimensions according to libgd 2.2.2+ shown extensively.

Nice to see it finally almost in.

Committed and pushed 419838e7841 to 11.x and 99e7d471466 to 11.3.x. Thanks!