Problem/Motivation

Seen the following when running our Functional Tests:
```
Deprecated: Creation of dynamic property Drupal\sharepoint_connector\SharepointConnector::$client_id is deprecated in /var/www/html/docroot/modules/contrib/sharepoint_connector/src/SharepointConnector.php on line 74

Deprecated: Creation of dynamic property Drupal\sharepoint_connector\SharepointConnector::$client_secret is deprecated in /var/www/html/docroot/modules/contrib/sharepoint_connector/src/SharepointConnector.php on line 75

Deprecated: Creation of dynamic property Drupal\sharepoint_connector\SharepointConnector::$tenant_id is deprecated in /var/www/html/docroot/modules/contrib/sharepoint_connector/src/SharepointConnector.php on line 76

Deprecated: Creation of dynamic property Drupal\sharepoint_connector\SharepointConnector::$base_url is deprecated in /var/www/html/docroot/modules/contrib/sharepoint_connector/src/SharepointConnector.php on line 77
```

Proposed resolution

I've looked at the code and the constructor already initializes these properties, so no further changes are needed in the constructor.

Adding the missing properties to the class definition resolves the issue found.

Comments

michelle-buckby created an issue. See original summary.

michelle-buckby’s picture

Issue summary: View changes
michelle-buckby’s picture

Issue summary: View changes

  • robbymo committed a7b057ce on 1.0.x
    Issue #3519256 Patch for PHP 8.2+ for Creation of dynamic property...
robbymo’s picture

Assigned: Unassigned » robbymo
Status: Active » Fixed

Thank you for bringing this to our attention michelle-buckby. We have incorporated your patch into the new 1.0.4 release! Marking this as fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.