Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Although PostgreSQL is officially supported by Drupal, many modules does not work with this (excellent) database.
Comment Notify module is not an exception:
- MySQL specific functions (concat, ifnull) used in install procedure
- MySQL specific "UPDATE table JOIN another_table SET ..." are used too.
Attached patch fixes these problems.
.install rewritten via 'db_type' == pgsql
.module: SQL queries rewriten to UPDATE comment_notify ... WHERE cid in (select cid from comments where...)
Patch attached. Tested only on PostgreSQL 8.3, may be string concatenation in .install should be rewriten with
explicit type casts (have no 7.x and 8.0-8.2 to test with)
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 351839_comment_notify_3_pgsql.patch | 3.33 KB | greggles |
| #2 | comment-notify-1.x-dev-20081229-pgsql.diff | 2.2 KB | Alex_Tutubalin |
| comment-notify-1.1-pgsql.diff | 2.65 KB | Alex_Tutubalin | |
Comments
Comment #1
gregglesThanks for the feedback and patch! Maintaining pgsql support is a major goal of mine in general and with this module.
I think that the fixes you made to the .module file are already included in the latest version because of #336394: Unable to disable notification. Although it doesn't seems we didn't catch it in
function comment_notify_unsubscribe_submit()Could you make those same fixes to the later queries and resubmit the patch?
Thanks!
Comment #2
Alex_Tutubalin CreditAttribution: Alex_Tutubalin commentedYes, one of "UPDATE {comments_notify} cn" is already fixed in -dev version.
Other issues remains.
Attached patch contains diff against 6.x-1.x-dev developmen snapshot (downloaded from module page).
Quick tested on small installation on PostgreSQL 8.3
Comment #3
gregglesHere's an alternate which just fixes spacing around the pgsql switch statement in the install and also around a foreach statement in the .module to comply with http://drupal.org/coding-standards
Comment #4
Alex_Tutubalin CreditAttribution: Alex_Tutubalin commentedI've saved initial spacing in .install just to 'not to patch' initial line
Comment #5
gregglesOk. I appreciate not wanting to change more lines than necessary but coding standards are even more important ;)
Thanks, this has been applied: http://drupal.org/cvs?commit=161346