The content of the poll block is full of hardcoded HTML. I consider all hardcoded HTML - which isn't inside theme_* functions - as a bug and file bug reports for them..

We should really improve this...

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Stefan Nagtegaal’s picture

Title: Poll block isn't themable » Poll results aren't themable
Assigned: Unassigned » Stefan Nagtegaal
FileSize
4.45 KB

See attached patch...
I tried to make the theme functions as clean as possible, and I think I did a great job..
I also did some code moving, and variable renaming to make it a little easier.

Please review and apply!

Stefan Nagtegaal’s picture

Status: Active » Needs review

Setting correct status...

Bèr Kessels’s picture

Looks good. It applies, and it seems to work. I do not havea site with polls, so I cannot see if it breaks existing polls.

A big +1 for the theme functions though. And also for the var_name clean ups (was namevar)

Stefan Nagtegaal’s picture

FileSize
4.38 KB

new patch as requested by steven

Stefan Nagtegaal’s picture

Status: Needs review » Reviewed & tested by the community

Tested quite intens, and setting this Ready to commit...

Stefan Nagtegaal’s picture

Updated as requested by Dries...

Stefan Nagtegaal’s picture

FileSize
4.36 KB

Renamed patch and uploaded new version

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)