Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The content of the poll block is full of hardcoded HTML. I consider all hardcoded HTML - which isn't inside theme_* functions - as a bug and file bug reports for them..
We should really improve this...
Comment | File | Size | Author |
---|---|---|---|
#7 | poll-themability.patch | 4.36 KB | Stefan Nagtegaal |
#6 | make-poll-results-themable_0.patch | 4.45 KB | Stefan Nagtegaal |
#4 | poll-module-themable.patch | 4.38 KB | Stefan Nagtegaal |
#1 | make-poll-results-themable.patch | 4.45 KB | Stefan Nagtegaal |
Comments
Comment #1
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedSee attached patch...
I tried to make the theme functions as clean as possible, and I think I did a great job..
I also did some code moving, and variable renaming to make it a little easier.
Please review and apply!
Comment #2
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedSetting correct status...
Comment #3
Bèr Kessels CreditAttribution: Bèr Kessels commentedLooks good. It applies, and it seems to work. I do not havea site with polls, so I cannot see if it breaks existing polls.
A big +1 for the theme functions though. And also for the var_name clean ups (was namevar)
Comment #4
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentednew patch as requested by steven
Comment #5
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedTested quite intens, and setting this Ready to commit...
Comment #6
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedUpdated as requested by Dries...
Comment #7
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedRenamed patch and uploaded new version
Comment #8
Dries CreditAttribution: Dries commentedCommitted to HEAD. Thanks.
Comment #9
(not verified) CreditAttribution: commented