Extra ellipsis in 'Logging and alerts' description [#349836]

Comment	File	Size	Author
#7	extra-ellipsis.patch	1022 bytes	lut4rp

#5	extra-ellipsis.patch	967 bytes	lut4rp

#4	extra-ellipsis.patch	1.15 KB	lut4rp

	extra-ellipsis.patch	967 bytes	lut4rp

Comment #1

lut4rp CreditAttribution: lut4rp commented 21 December 2008 at 18:22

Assigned:

Unassigned

» lut4rp

Log in or register to post comments

Comment #2

keith.smith CreditAttribution: keith.smith commented 21 December 2008 at 18:36

Component:	system.module	» user interface text
Status:	Active	» Needs work

Yes, your patch does correct a needless ellipsis.

But, in the new string:

Settings for logging and alerts modules. Various modules can route Drupal's system events to different destination, such as syslog, database, email etc.

There are a few issues. "destination" should be plural, and there should be a comma between "email" and "etc".

But, if it were me, I'd just end the string after the first sentence. That second sentence is not needed, IMO.

Log in or register to post comments

Comment #3

lut4rp CreditAttribution: lut4rp commented 21 December 2008 at 18:52

I checked Wikipedia and here's what it recommends...

Generally, however, a comma is not used before and, or or etc. in a list: "John, Warren and Peter came to dinner." "Fruit, vegetables or cereals may be substituted." "Why not hire your skis, boots, overpants etc.?"

So, the statement should be...

Settings for logging and alert modules. Various modules can route Drupal's system events to different destinations, such as syslog, database, email etc.

I think alerts should be changed to alert. Sounds more correct?

Log in or register to post comments

Comment #4

lut4rp CreditAttribution: lut4rp commented 21 December 2008 at 18:55

File	Size
extra-ellipsis.patch	1.15 KB

Log in or register to post comments

Comment #5

lut4rp CreditAttribution: lut4rp commented 21 December 2008 at 18:59

File	Size
extra-ellipsis.patch	967 bytes

Oops, the last patch had an extra space.

Log in or register to post comments

Comment #6

keith.smith CreditAttribution: keith.smith commented 21 December 2008 at 19:14

No reason to have dueling wikipedia entries, but the entry at http://en.wikipedia.org/wiki/Et_cetera seems to contradict your post above.

Typically, the abbreviated versions should always be followed by a full stop (period), and it is customary—even in British English where the serial comma is typically not used—that "etc." always be preceded by a comma. Thus:

A, B, C, etc.

not:

A, B, C etc

Unfortunately, I'm not near my Chicago Manual of Style nor any other style guide at the moment for a more definitive reference.

Log in or register to post comments

Comment #7

lut4rp CreditAttribution: lut4rp commented 30 January 2009 at 20:15

File	Size
extra-ellipsis.patch	1022 bytes

I just spend some time researching this on the web and in ##english. keith.smith, you're right, there should be a comma before the "etc." as well.
Re-rolling and attaching the new patch.