Problem/Motivation

Gin's composer.json requires a beta version of gin_toolbar.

Proposed resolution

Gin 4.0 should require ^2.0 and Gin 3.0 should require ^1.0.

Comments

jurgenhaas created an issue. See original summary.

  • jurgenhaas committed 50d458d8 on 8.x-3.x 
    Issue #3495288 by jurgenhaas: Clean-up composer constraint for...

  • jurgenhaas committed 5a583500 on 4.0.x 
    Issue #3495288 by jurgenhaas: Clean-up composer constraint for...
jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Active » Fixed
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

@jurgenhass thanks for fixing this I thought I needed to. I created this dupe #3495379: Allow gin_toolbar 2.0 to install

Could you do a patch release when you get a chance? Thanks for updating this!

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

@joelpittet we didn't plan for a patch release because it doesn't really matter if you have gin_toolbar 1.0 or 2.0 because they are currently identical. Moving forward, 2.0 will progress and by then, a patch release will have been available if not earlier.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Oh sorry, I was just trying to reproduce a bug but ran into this, if they are identical then yeah it doesn’t matter, sorry to bother. My bug was in environment_indicator in the end.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

I believe a patch release is still useful, to make things more future/proof.

i.e., I am running updates and happily update gin_toolbar to 4.0 but can't do 2.0 which I have to remember next batch of updates. I know it's a little thing, but so is releasing a patch release.

Just my 2c, congrats and thanks a lot!

klemendev’s picture

klemendev commented

So this is fixed, but not released, right? Because I still can't update toolbar to 2.0 due to version constraints with Gin 4.0.0

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

@klemendev correct

klemendev’s picture

klemendev commented

Thanks for the clarification and happy holidays!

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

As a reference also for others who come along and find this issue:

If you require drupal/gin:^4 in your Drupal projects, that's sufficient, and you don't have to explicitly require the toolbar project. With composer, you get this automatically. For now, you still get version 1 of the toolbar, which is identical with version 2. So, nothing to worry about. As soon as there is a patch release of the Gin theme, the updated constraint will be delivered and that will then automatically update the toolbar to version 2. All this happens without the user/developer having to do anything.

sense-design’s picture

sense-design
sense
Primary language German
Location Münster
commented

Fixed in 4.0.1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.