Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
This is a child issue of #3404246: [META] Fix strict type errors detected by phpstan in order to reduce the scope.
The scope includes any issues detected by FunctionCallParametersCheck where the function is expecting an int but receiving a float. This seems to occur when using functions like round or ceil that return float.
Steps to reproduce
See parent
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3461945
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3461945-float-to-int
changes, plain diff MR !8798
Comments
Comment #3
mstrelan commentedComment #4
bbralaThe three calls are ceil and round. Which means we are not running into the problem that (int) cast will always round down. Changes are clear, output is correct. RTBC for me.
Comment #7
catchCommitted/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!