The included test used to fail due to this issue. Discussed in IRC after mikey_p discovered.

Originally discover by the fact that http://drupalbin.com/4438 passed.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

boombatower’s picture

Title: SimpleTest correct assertTitle logic » SimpleTest: correct assertTitle logic

Added assertNoTitle for consistency and to be able to write test.

boombatower’s picture

Assigned: Unassigned » boombatower
Category: task » bug
boombatower’s picture

davereid caught documentation issue.

Dave Reid’s picture

Assigned: boombatower » Unassigned
Category: bug » task

Makes complete sense to add assertNoTitle since assertTitle is one of the only assertions that doesn't include a negative. Also helpful to make sure that assertTitle works correctly like we discovered it does not. Docs need a tweak: "The string the title should NOT be."

boombatower’s picture

Assigned: Unassigned » boombatower
Category: task » bug
FileSize
2.06 KB

Too fast on trigger finger.

Dave Reid’s picture

Assigned: boombatower » Unassigned
Category: bug » task
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly and fixes an uncaught error that will not be missed again now! RTBC

boombatower’s picture

Assigned: Unassigned » boombatower
Category: task » bug
FileSize
2.05 KB

chx noted that assertTrue|False would be more appropriate (been away too long)

Dave Reid’s picture

Still confirming RTBC. #7 is good to go.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Dave Reid’s picture

Priority: Normal » Critical
Status: Fixed » Needs review
FileSize
879 bytes

Testing bot did not catch a failure now that assertTitle works properly.

boombatower’s picture

Really need to figure out why some slaves do not catch all the issues

Dave Reid’s picture

FileSize
817 bytes

Revised patch that uses "Preview | Drupal" like the rest of core tests.

Dave Reid’s picture

Looks like its only slave #4 that is picking up the broken-ness. All others, no.

boombatower’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

boombatower’s picture

@11: We figured out the issue...so the testing bot misses should no longer occur. #338292: Correct regex for singular assertions

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.