Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The included test used to fail due to this issue. Discussed in IRC after mikey_p discovered.
Originally discover by the fact that http://drupalbin.com/4438 passed.
Comment | File | Size | Author |
---|---|---|---|
#12 | head-broken-D7.patch | 817 bytes | Dave Reid |
#10 | head-broken-D7.patch | 879 bytes | Dave Reid |
#7 | simpletest_assertTitle.patch | 2.05 KB | boombatower |
#5 | simpletest_assertTitle.patch | 2.06 KB | boombatower |
#3 | simpletest_assertTitle.patch | 2.3 KB | boombatower |
Comments
Comment #1
boombatower CreditAttribution: boombatower commentedAdded assertNoTitle for consistency and to be able to write test.
Comment #2
boombatower CreditAttribution: boombatower commentedComment #3
boombatower CreditAttribution: boombatower commenteddavereid caught documentation issue.
Comment #4
Dave ReidMakes complete sense to add assertNoTitle since assertTitle is one of the only assertions that doesn't include a negative. Also helpful to make sure that assertTitle works correctly like we discovered it does not. Docs need a tweak: "The string the title should NOT be."
Comment #5
boombatower CreditAttribution: boombatower commentedToo fast on trigger finger.
Comment #6
Dave ReidPatch applies cleanly and fixes an uncaught error that will not be missed again now! RTBC
Comment #7
boombatower CreditAttribution: boombatower commentedchx noted that assertTrue|False would be more appropriate (been away too long)
Comment #8
Dave ReidStill confirming RTBC. #7 is good to go.
Comment #9
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks!
Comment #10
Dave ReidTesting bot did not catch a failure now that assertTitle works properly.
Comment #11
boombatower CreditAttribution: boombatower commentedReally need to figure out why some slaves do not catch all the issues
Comment #12
Dave ReidRevised patch that uses "Preview | Drupal" like the rest of core tests.
Comment #13
Dave ReidLooks like its only slave #4 that is picking up the broken-ness. All others, no.
Comment #14
boombatower CreditAttribution: boombatower commentedLooks good.
Comment #15
boombatower CreditAttribution: boombatower commented@11: We figured out the issue...so the testing bot misses should no longer occur. #338292: Correct regex for singular assertions
Comment #16
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.