Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Merge Request Only
Although the activity is all taking place within Gitlab, this issue exists so it has some form of representation in the queue as many are accustomed to having all activity in a project associated with an issue. MR-only issues such as these exist for "setup" issues that will unlock many additional tasks once they land. Those additional unlocked tasks will use the issue queue in the manner contributors are more accustomed to.
Proposed resolution
- PoC UI to change the expression used for a
sourceType == dynamicprop value - PoC UI to toggle between
sourceType:from dynamic tostatic:field_item:…and back - Get rid of
experience_builder_entity_view_alter() - Get adapter sources working too.
- Initial end-to-end functional test: fde818b82da0fd50c5bec7bbccf449f8c76bc4e3
That looks like this:
Try it locally:
vendor/bin/drush si standard --account-name=root --account-pass=root --yes
vendor/bin/drush pm:install experience_builder --yes
# navigate to /node/add/article and observe!
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | XB-field-widget-choose-prop-source.gif | 5.08 MB | wim leers |
Comments
Comment #2
wim leersClarifying issue title.
Comment #4
wim leersFollow-up issues exist for out-of-scope but problems/todos surfaced here, with the exception of 2 that @larowlan graciously offered to create 🙏
(I did not implement the caching pieces @larowlan suggested, because it's too early to do add any caching — that only makes sense to add when the codebase is approaching its final shape, otherwise we risk premature optimization.)
CI is green.
Ready for final review.
Comment #5
wim leersThis blocks #3452497: [MR Only] Edit any component prop, powered by a new FieldForComponentSuggester service, which will power the JS UI.
Comment #6
wim leersComment #7
wim leersComment #8
wim leersAnd … here's a GIF showing it in action!
Comment #10
wim leersRTBC: @f.mazeikis approved the MR. (This was the last issue that was created for an already in-progress MR, we'll default to issue forks going forward, which will be less confusing for Drupal contributors — at the cost of more confusing DX, which is fine!)
Comment #12
wim leersGiven the very strong stabilizing impact of
EndToEndDemoIntegrationTest, I don't want to wait to merge this until @larowlan also explicitly approves.Having this in means next week will be more productive, because this test will serve as the https://en.wiktionary.org/wiki/canary_in_a_coal_mine for the data model/storage back-end infrastructure. 🐣
P.S.: I do have a follow-up @larowlan requested on this MR green & ready for him: #3453152: Centralize & standardize logic for constructing *PropSource objects + kernel test coverage 🤓
Comment #13
wim leersAlso see @ctrlADel's write-up at #3452023-5: Research JSON schema forms for SDC configuration, where he agrees with this direction even though he started out from a very different angle.