very small patch from looking at drupal_install_system as part of #340052: speedup simpletest by preloading the registry.

* we call drupal_init_database twice for no apparent reason
* drupal_install_init_database has a static variable that appears to be guarding against running its body twice, but its not updated on the first run

attached patch fixes these issues.

CommentFileSizeAuthor
dont_init_db_twice.patch1.06 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

swentel’s picture

swentel CreditAttribution: swentel commented

Installing works after this patch, let's hope the testbot is happy too :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs review » Fixed

Nice catch; this was completely silly.

Committed to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.