Photoswipe field formatter settings are reset in Layout Builder updating from 4.x to 5.x

Someone please needs to find out, if this only happens for formatters within layout builder or also happens for regular entity formatters.

photoswipe_update_9003()
is responsible for updating the field formatters.

So could someone please provide details, when this happens and when not?

My bet is, that this is "just" an issue with layout builder. Layout builder leads to different structures in the entity displays that need to be handled.

Luckily I found some other projects that had similar issues and code:

• #3251489: updb doesn't check layout builder fields. (fixed)
• #3364904: Update the link setting for Title Formatter in Layout Builder. (to review)

Guess we can be quite sure such a solution needs to be adopted?

Ok, I just tested this, and indeed the formatter settings are only still there for entities NOT using Layout Builder. Any entity using layout builder will have all of their formatter settings reset (except "Photoswipe modal image style" for some reason).

Fixed and tested, works like a charm!

Nice work @Grevil! I left some final comments to make it more bulletproof. Afterwards please test it one last time and I'll do the final review!

Very well done!

Seems we were too quick:

[notice] Update started: photoswipe_update_9005
[warning] Undefined array key "photoswipe_caption" photoswipe.install:276
[warning] Undefined array key "photoswipe_caption_custom" photoswipe.install:277
[warning] Undefined array key "photoswipe_node_style" photoswipe.install:284
[warning] Undefined array key "photoswipe_node_style_first" photoswipe.install:285
[notice] Update completed: photoswipe_update_9005

and in one case photoswipe_caption: 'alt' was modified to null

Fixed, I'll tag 5.0.0-beta1 now!