Problem/Motivation

Course "open date" isn't displaying for other then English languages. Thats because group--course-basic--hero.html.twig template has condition by field_course_opening_status boolean field label rather then field value.
But field labels can be translated (or even overridden), so we should not relay on field label and use value instead.

Steps to reproduce

  1. Change values labels for field_course_opening_status field on admin/group/types/manage/course_advanced/fields/group.course_advanced.field_course_opening_status
  2. Create an advanced course with future start date
  3. Visit course view page and see that start date disappears on "hero" section

Proposed resolution

Change condition checks from label to value

Remaining tasks

n/a

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Issue fork social_course-3385849

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vnech created an issue. See original summary.

vnech opened merge request !45

vnech’s picture

vnech commented
Status: Active » Needs review

  • vnech committed fd4c8be6 on 5.1.x 
    Issue #3385849 by vnech: Course open date displays correctly for all...

  • ribel committed 1c8da8f6 on 5.0.x authored by vnech 
    Issue #3385849 by vnech: Course open date displays correctly for all...
ribel’s picture

ribel
Primary language Ukrainian
Location 🇺🇦Lviv
commented
Version: 5.0.9 » 5.0.10
Status: Needs review » Fixed

Tested and approved.
Merged and released in version 5.0.10.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.