Problem/Motivation

The table markup was changed after the update to Gin 3.0.0-rc5, a new parent node was added for the table, thus breaking the add in between button.

Steps to reproduce

Edit an article with paragraphs, the "Add" buttons do not appear in between paragraphs.

Proposed resolution

Introduce another case in getAddModalBlock for table.parentNode.parentNode

PR

https://github.com/thunder/paragraphs_features/pull/74

CommentFileSizeAuthor
#4 fix-add-modal-block_gin.patch705 bytesalex_ieremia

Comments

alex_ieremia created an issue. See original summary.

alex_ieremia’s picture

alex_ieremia commented
Issue summary: View changes
alex_ieremia’s picture

alex_ieremia commented
Issue summary: View changes
alex_ieremia’s picture

alex_ieremia commented
StatusFileSize
new fix-add-modal-block_gin.patch705 bytes
alex_ieremia’s picture

alex_ieremia commented
Title: Add in between breaks in Gin 3.0.0-rc5 update » In between buttons break in Gin 3.0.0-rc5 update
alex_ieremia’s picture

alex_ieremia commented
Status: Active » Needs review
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Reviewed & tested by the community

reviewed and tested, works good again after applying the patch!
without the patch the add-in-between button are simply gone.

alex_ieremia’s picture

alex_ieremia commented
volkerk’s picture

volkerk commented
Status: Reviewed & tested by the community » Fixed

Needs patch from https://www.drupal.org/project/gin/issues/3375350 as well, we do not have a dependency on gin, so we cannot add the patch here.

  • chr.fritsch authored 2fef71ff on 2.x 
    Issue #3380569: Fix getAddModalBlock for Gin 3.0.0-rc5 (#75)

Needs...

  • chr.fritsch authored 2fef71ff on 2.x 
    Issue #3380569: Fix getAddModalBlock for Gin 3.0.0-rc5 (#75)

Needs...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.