Problem/Motivation

The autocomplete icon is not clearly visible when using dark mode

Steps to reproduce

Click on any autocomplete field and start typing then the user will notice autocomplete icon appears for some time and have some color issue in the dark mode

Proposed resolution

Needs to change color as per the dark mode.

bug

CommentFileSizeAuthor
#7 After-patch.mp48.91 MBdjsagar
#6 3375729-6.patch2.32 KBHarish1688
#6 interdiff_1-6.txt3.28 KBHarish1688
#6 3375729 second color.png65.96 KBHarish1688
#6 3375729 first color .png57.39 KBHarish1688
#4 after.png151.09 KBamietpatial
#2 3375729-1.patch1.79 KBmukesh-kumar3
gin-autocomplete.png143.33 KBmukeysh

Comments

Mukeysh created an issue. See original summary.

mukesh-kumar3’s picture

mukesh-kumar3 commented
StatusFileSize
new 3375729-1.patch1.79 KB

Adding patch for above fix. Please review

mukesh-kumar3’s picture

mukesh-kumar3 commented
Status: Active » Needs review
amietpatial’s picture

amietpatial commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after.png151.09 KB

Patch #2 applied and after before screenshots attached.

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Needs work

This should support accent color, so moving this back to needs work

Harish1688’s picture

Harish1688 commented
Status: Needs work » Needs review
StatusFileSize
new 3375729 first color .png57.39 KB
new 3375729 second color.png65.96 KB
new interdiff_1-6.txt3.28 KB
new 3375729-6.patch2.32 KB

Hi,

As pr last comment #5, create a new patch (3375729-6.patch), in last patch no accent color variables are used, except using a background SVG in case when we switch the primary color from GIN setting, loader color image remain the same color that issue resolved in new patch.
images attached to reference. Needs Review.

Testing steps:
1. setup the Drupal 10.1.x and enable the Gin 8.x-3.
2. applied the patch on path 'drupal/themes/contrib/gin', then moved to '/admin/appearance/settings/gin' switch to any primary color in both mode (light/Dark).
3. moved to node like 'node/add/article' , check the autocomplete like tag field type text loader will be show right side.

After patch:
issue image
issue image

djsagar’s picture

djsagar commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new After-patch.mp48.91 MB

Applied Patch #6 and it's resolved issue sharing attachment for reference.

Thanks!

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Fixed

Great, thanks! 👏

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.