Problem/Motivation

I ran into this with the Wave scanner. While there's no user need to have sufficient contrast on visually hidden elements, if a scanner reports a contrast error it gives the impression that Gin is less accessible than it really is. While it's true this is ultimately a problem with the A11y scanner, we can update the text color of visually hidden elements pretty easily and in a non-disruptive way, so why not do this to ensure Gin accessibility scans do not report irrelevant errors.

Steps to reproduce

Run the Wave scanner on any page with the secondary toolbar present and note the contrast errors https://wave.webaim.org/extension/

Run that same scanner on pretty much any page in dark mode and note even more contrast errors.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork gin-3374716

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

bnjmnm created an issue. See original summary.

bnjmnm’s picture

Issue summary: View changes
Status: Active » Needs review

Added some CSS to explicitly set color in .visually-hidden elements.

saschaeggi made their first commit to this issue’s fork.

saschaeggi’s picture

Status: Needs review » Reviewed & tested by the community

Tested LGTM, merging

  • saschaeggi committed 8cbb6b8b on 8.x-3.x authored by bnjmnm
    Issue #3374716: Prevent innacurate "insufficent contrast" errors from...
saschaeggi’s picture

Status: Reviewed & tested by the community » Fixed

Thx!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.