Problem/Motivation

The original issue was found inside #3300426: Views viewsScrollTop (ScrollTopCommand AJAX command) doesn't work inside Drupal Off canvas dialogs. This issue is dedicated to only fix the original scrolling issue.

The problem is, that in a recent Drupal release, the AjaxCommand "viewsScrollTop" was renamed to "scrollTop". Meaning, that the removal of this command is not given inside "AjaxResponseSubscriber" and instead we are removing the old "viewsScrollTop" which does NOT exist in recent releases.

Steps to reproduce

Use a keyboard to navigate through an Infinite Scroll View with a "Load more" pager.
Expected: After hitting enter on "Load More", the first new node gets focus.
Actual: hitting tab takes you to the element following the view.

Proposed resolution

To ensure backwards compatibility, we should remove both the "scrollTop" and the "viewsScrollTop" command.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#13 16.patch3.48 KB2dareis2do

Issue fork views_infinite_scroll-3371899

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grevil created an issue. See original summary.

grevil’s picture

grevil commented
Issue summary: View changes
grevil’s picture

grevil commented
Priority: Normal » Major

Grevil opened merge request !15

grevil’s picture

grevil commented
Status: Active » Needs review

Works great! Please review! :)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

@Grevil: Please add a comment and eventually link to the change record to explain the change.
RTBC afterwards, just missing the explanation.

grevil’s picture

grevil commented
Status: Needs work » Needs review

Done. Is the explanation enough?

Grevil closed merge request !15

Grevil opened merge request !16

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Thanks, I think that's fine!

Hopefully this can be merged soon, currently this is broken with Drupal 10.x!

isaacrc’s picture

isaacrc commented

I can also confirm that the patch fixed the issue in Drupal 10.1 Thanks!

2dareis2do’s picture

2dareis2do commented

How can I apply this patch?

2dareis2do’s picture

2dareis2do commented
StatusFileSize
new 16.patch3.48 KB
2dareis2do’s picture

2dareis2do commented

Ok works for me on drupal 10.1

zenimagine’s picture

zenimagine commented

Patch #14 works for me with Drupal 10.1

  • Anybody committed a4727574 on 2.0.x authored by Grevil 
    Issue #3371899 by Grevil, Anybody: Do not scroll to top, when loading...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Thanks @Grevil, merged. New stable release soon!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.