Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
As explained in comment #13:
CL Block is still not compatible with the 2.x series and with SDC in core.
There are multiple things to fix in order to make this module compatible.
Proposed resolution
Identify and fix all the issues found and produce a single patch.
Remaining tasks
- Patch/MR
- Test
- Review
User interface changes
- N/A
API changes
- N/A
Data model changes
- Some references to SDC components classes will be moved to the core ones, but the functionality of this module should not be affected by those changes.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 3367477-11.patch | 797 bytes | rajab natshah |
Issue fork cl_block-3367477
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
rajab natshahComment #3
rajab natshahComment #4
rajab natshahComment #5
rajab natshahComment #6
rajab natshahNot sure if this issue should be moved to the Component Libraries: Blocks project.
Comment #7
rajab natshahComment #8
rajab natshahComment #10
rajab natshahComment #11
rajab natshahComment #12
rajab natshahComment #13
e0ipsoI am surprised this is the only issue you encountered so far. CL Block is still not compatible with the 2.x series and with SDC in core.
Can we turn this issue into a more generic issue for SDC compatibility?
Comment #14
rajab natshahThanks for passing by this issue.
Yes, for sure if you like that.
I had one issue before this one
#3365591: Fix Block Settings TypeError: array_filter() when pressing Save configuration
Today I faced the following issue too.
#3371765: Fix TypeError when editing Text formats and editors for the Cl Component Embed filter having Argument #1 ($input) must be of type array, null given
It feels that a one refactor issue could manage refactoring the code to support SDC from Drupal
~10.1.0and CL family of modules to be inline with the2.0.xbranches.More testing rounds and experimentation with all dynamic config and behaviors.
Comment #15
rajab natshahComment #16
jidrone commentedI agree with @e0ipso, I was trying to make it work with the latest version of Drupal core and all other modules and I have found more things to fix, so instead of having a lot of small issues that don't work independently I would rename this for all the compatibility issues.
Once the patch get ready maybe we can create a 2.x version.
Comment #17
jidrone commentedComment #19
jidrone commentedI started a new issue fork and MR with multiple fixes:
There are some things I didn't test yet, like the CK editor embed, I will move it to needs review for now.
Comment #20
e0ipso@jidrone it really shows that you have been getting familiar with the codebase! This MR is absolutely fantastic!
I left a bunch of comments in the MR.
Some overarching questions & requests:
sdc_tagsas part ofcl_editorialto deal with the configuration form on what components are eligible for each feature. Can we also migrate to that as well, or create a ticket to do so? There is an example on how to do it insdc_display@jidrone I think this is great for Layout Builder workflows and sites sticking behind with CKEditor4, but in the future I'd like to break this module in two:
sdc_blockandsdc_ckeditor. What do you think about this?Comment #21
jidrone commentedYes, I think the CKEditor integration should be in a separate module.