Problem/Motivation

In details elements that are inside of a vertical tab, the content wrapper (.details-wrapper) may overflow the detail. See attached screenshot, where the "Donate" details right-hand border is mostly invisible because the content is laid over it.

Steps to reproduce

On a form, create a vertical_tabs element. In one of the child details tabs, add a further detail sub-element.

Proposed resolution

It looks like all details wrappers inherit these styles in tabs.scss if they are inside a vertical tab:

.vertical-tabs {
  &__items {
    .vertical-tabs__item {
      .claro-details__wrapper {
        display: inline-block;
        width: 100%;
      }
    }
  }
}

Adding a > direct descendent selector before .claro-details__wrapper should limit this block to just the intended target, the details element that is acting as tab content.

CommentFileSizeAuthor
gin-details-overflow.png25.86 KBbvoynick

Issue fork gin-3360757

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

bvoynick created an issue. See original summary.

bvoynick’s picture

Status: Active » Needs review

Harish1688’s picture

Hi @bvoynick,

Please provide additional steps to replicate the issue on a local system. More information is needed for accurate replication.

saschaeggi made their first commit to this issue’s fork.

  • saschaeggi committed 617ac54a on 8.x-3.x authored by bvoynick
    Issue #3360757: Details elements inside of a vertical tab break out of...
saschaeggi’s picture

Status: Needs review » Fixed

Great, thanks for the fix, bvoynick 🙇

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.