Problem/Motivation

On the issue https://www.drupal.org/project/drupal/issues/2513586 the text "You must include at least one positive keyword with 1 character or more." was changed. To use the same words as the core and avoid duplicate translations, update the message.

CommentFileSizeAuthor
#7 3356817-7--required_keywords_warning_text.patch2.67 KBdrunken monkey
#7 3356817-7--required_keywords_warning_text--interdiff.txt1.75 KBdrunken monkey
#5 3356817-5--required_keywords_warning_text.patch937 bytesdrunken monkey
#5 3356817-5--required_keywords_warning_text--interdiff.txt1.07 KBdrunken monkey

Issue fork search_api-3356817

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Eduardo Morales Alberti created an issue. See original summary.

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Parent issue: » #2513586: Remove the word "positive" from the "Must include a positive keyword with three characters or more." error message

Eduardo Morales Alberti opened merge request !76

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Status: Active » Needs review
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Component: General code » User interface
StatusFileSize
new 3356817-5--required_keywords_warning_text--interdiff.txt1.07 KB
new 3356817-5--required_keywords_warning_text.patch937 bytes

Thanks for the suggestion, sounds like a good idea.
The formatPlural() call was slightly wrong, should be fixed in the attached patch. (Testing for pull requests doesn’t work in this project, unfortunately, as you can see.)

Status: Needs review » Needs work

The last submitted patch, 5: 3356817-5--required_keywords_warning_text.patch, failed testing. View results

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review
StatusFileSize
new 3356817-7--required_keywords_warning_text--interdiff.txt1.75 KB
new 3356817-7--required_keywords_warning_text.patch2.67 KB

Makes sense.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Merged.
Thanks again!

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented

Thank you!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.