Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Damien mentioned that getActiveConnection does and then I realized it's copypasted.
Comment | File | Size | Author |
---|---|---|---|
#3 | 335614.patch | 6.05 KB | Damien Tournoud |
#2 | 335614.patch | 5.99 KB | Damien Tournoud |
#1 | 335614.patch | 4.41 KB | Damien Tournoud |
openconnection_key.patch | 633 bytes | chx | |
Comments
Comment #1
Damien Tournoud CreditAttribution: Damien Tournoud commentedgetActiveConnection() and getConnection() were buggy anyway: if called on a non existing target, openConnection() will be called each time, because the target will not be found in self::$connections
Comment #2
Damien Tournoud CreditAttribution: Damien Tournoud commentedBug description: all getConnection() twice with the same unknown $target... openConnection() is called twice...
Now with a unit test case.
Comment #3
Damien Tournoud CreditAttribution: Damien Tournoud commentedNow with some less incorrect English.
Comment #4
Dries CreditAttribution: Dries commentedMakes sense, and the tests made it easy to understand and review. Committed to CVS HEAD. Thanks a lot.