Problem/Motivation

I was exploring some issues I was having and noticed I hadn't set up an encryption profile yet. When to do so and got the following after the first save:

TypeError: Drupal\drd\EncryptionUpdate::update(): Argument #1 ($old_profile_id) must be of type string, null given, called in /app/web/modules/contrib/drd/src/Form/Settings.php on line 214 in Drupal\drd\EncryptionUpdate->update() (line 69 of /app/web/modules/contrib/drd/src/EncryptionUpdate.php).

Steps to reproduce

New install of Drupal 10
Install Drd
Install real aes
Create your key
create your encryption profile
add a host
go to /drd/cores/add
Click on link in error message to navigate to drd/settings
Select the newly created encryption profile

Proposed resolution

Need to do some error checking over here because $old_profile_id doesn't exist yet.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork drd-3347429

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

generalredneck created an issue. See original summary.

generalredneck opened merge request !14

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
CreditAttribution: generalredneck at Four Kitchens commented
Version: 4.1.0-alpha2 » 4.1.x-dev
Status: Active » Needs review

Simple quick fix. There's no old profile to update from so no need to call EncryptionUpdate.

jurgenhaas made their first commit to this issue’s fork.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
CreditAttribution: jurgenhaas at LakeDrops commented
Status: Needs review » Fixed

Nice one, thanks @generalredneck

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.