Capitalize the name of the module, because module names are proper nouns.
https://www.drupal.org/docs/develop/creating-modules/let-drupal-know-abo...
Patch to follow, thanks!

CommentFileSizeAuthor
#4 code-after-patch.png73.48 KBclarkssquared
#4 code-before-patch.png97.39 KBclarkssquared
#2 3343620-1.patch516 bytessahana _n

Issue fork login_emailusername-3343620

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3343620-2 Comparechanges, plain diff MR !4
    • 1 hidden branch
  • 8.x-1.x Comparecompare
About issue forks

Comments

Sahana _N created an issue. See original summary.

sahana _n’s picture

sahana _n commented
Status: Active » Needs review
StatusFileSize
new 3343620-1.patch516 bytes

Please review the patch.

Rashmisoni made their first commit to this issue’s fork.

clarkssquared’s picture

clarkssquared commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new code-before-patch.png97.39 KB
new code-after-patch.png73.48 KB

Hi Sahana_N,

I'm new to this module and confirmed resolved the issue when I applied patch #2 to the "Login Email or Username" module against version "2.0.0". Please see the screenshots attached.

For your review.
Thank you.

renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Needs work

Seems good, but needs re-roll and we can also update the composer.json with the new label as well

RenatoG opened merge request !4

renatog’s picture

renatog commented
Status: Needs work » Needs review

MR created with the fix https://git.drupalcode.org/project/login_emailusername/-/merge_requests/4

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

RTBC for MR!4

vladimiraus changed the visibility of the branch 8.x-1.x to hidden.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Version: 2.0.0 » 3.0.x-dev

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Priority: Normal » Minor
Status: Reviewed & tested by the community » Fixed

Thanks all. Committed. 🥃

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.