I believe it should be:
A comma-separated list of terms describing this content. Example: funny, bungee jumping, "Company, Inc."

Yes no period. My copy editor, made the comment, and I said, well that's at the core. I did a grep and found it was in this module:
modules/taxonomy/taxonomy.module

I made the edit, but I just thought I would let you know. She told me the period at the end of Inc. does the job to abbreviate Incorporation, and end the sentence. I am not english grammar nazi, but we might as well make this grammatically correct.

CommentFileSizeAuthor
#7 333478-7.patch3.03 KBkeith.smith
#3 333478.patch3.11 KBkeith.smith
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

keith.smith’s picture

Version: 6.3 » 7.x-dev
Component: taxonomy.module » user interface text

We'd have to do this for 7.x and forward, as 6.x strings are frozen for translation (and it's arguably not worth breaking translations to eliminate an extra period).

beekerstudios’s picture

Agreed, but I thought I would do my part and notify.

keith.smith’s picture

Status: Active » Needs review
FileSize
3.11 KB

Strictly speaking, those ending periods are unnecessary in these few cases, due to the order of the keywords.

Who knew we talked about bungee jumping so often in core.

And, further, why do we refer to keywords as "character sequences"? I think that's somewhat stilted, but perhaps there's some sort of transliteration or translation reason for doing so.

joachim’s picture

Similarly to http://drupal.org/node/242048, I think 'bungee jumping' and 'funny' should be replaced with something a bit more suitable for the average site.

Damien Tournoud’s picture

Could we change "character sequences" by something less geeky? "Sentence" for example?

catch’s picture

phrases, maybe? Character sequences is terrible.

keith.smith’s picture

FileSize
3.03 KB

Maybe "phrases" will work. Thanks catch.

Status: Needs review » Needs work

The last submitted patch failed testing.

catch’s picture

Status: Needs work » Needs review

broken HEAD.

Morbus Iff’s picture

As the original writer of that sentence with the extra ending period, I gasp.
Definitely should not have the additional period - the one in Inc. is good enough.

catch’s picture

Status: Needs review » Reviewed & tested by the community
Morbus Iff’s picture

[catch: to clarify I looked at the patch but did not ACTUALLY patch the source and test to
ensure things continued to work; therefore, I did NOT change the state to "tested by"]

catch’s picture

Morbus, yes I set this to RTBC because there was agreement, with this string change I think it's fine to rely on the test bot to ensure everything works.

joachim’s picture

Can we deal with bungee jumping or is that for another issue and another patch?

Morbus Iff’s picture

Bungee jumping is opinion-based. The terminating period is a fact.

Let's get facts straightened out and then care about stupid shit ;)

webchick’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +Quick fix

Cool! Committed to HEAD. I agree; let's get rid of "bungee jumping" next.

I don't think we can back-port this to D6 because it would break translations.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.