Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I believe it should be:
A comma-separated list of terms describing this content. Example: funny, bungee jumping, "Company, Inc."
Yes no period. My copy editor, made the comment, and I said, well that's at the core. I did a grep and found it was in this module:
modules/taxonomy/taxonomy.module
I made the edit, but I just thought I would let you know. She told me the period at the end of Inc. does the job to abbreviate Incorporation, and end the sentence. I am not english grammar nazi, but we might as well make this grammatically correct.
Comment | File | Size | Author |
---|---|---|---|
#7 | 333478-7.patch | 3.03 KB | keith.smith |
#3 | 333478.patch | 3.11 KB | keith.smith |
Comments
Comment #1
keith.smith CreditAttribution: keith.smith commentedWe'd have to do this for 7.x and forward, as 6.x strings are frozen for translation (and it's arguably not worth breaking translations to eliminate an extra period).
Comment #2
beekerstudios CreditAttribution: beekerstudios commentedAgreed, but I thought I would do my part and notify.
Comment #3
keith.smith CreditAttribution: keith.smith commentedStrictly speaking, those ending periods are unnecessary in these few cases, due to the order of the keywords.
Who knew we talked about bungee jumping so often in core.
And, further, why do we refer to keywords as "character sequences"? I think that's somewhat stilted, but perhaps there's some sort of transliteration or translation reason for doing so.
Comment #4
joachim CreditAttribution: joachim commentedSimilarly to http://drupal.org/node/242048, I think 'bungee jumping' and 'funny' should be replaced with something a bit more suitable for the average site.
Comment #5
Damien Tournoud CreditAttribution: Damien Tournoud commentedCould we change "character sequences" by something less geeky? "Sentence" for example?
Comment #6
catchphrases, maybe? Character sequences is terrible.
Comment #7
keith.smith CreditAttribution: keith.smith commentedMaybe "phrases" will work. Thanks catch.
Comment #9
catchbroken HEAD.
Comment #11
Morbus IffAs the original writer of that sentence with the extra ending period, I gasp.
Definitely should not have the additional period - the one in Inc. is good enough.
Comment #12
catchComment #13
Morbus Iff[catch: to clarify I looked at the patch but did not ACTUALLY patch the source and test to
ensure things continued to work; therefore, I did NOT change the state to "tested by"]
Comment #14
catchMorbus, yes I set this to RTBC because there was agreement, with this string change I think it's fine to rely on the test bot to ensure everything works.
Comment #15
joachim CreditAttribution: joachim commentedCan we deal with bungee jumping or is that for another issue and another patch?
Comment #16
Morbus IffBungee jumping is opinion-based. The terminating period is a fact.
Let's get facts straightened out and then care about stupid shit ;)
Comment #17
webchickCool! Committed to HEAD. I agree; let's get rid of "bungee jumping" next.
I don't think we can back-port this to D6 because it would break translations.