Update Gutenberg library [#3334499]

Usually we use the same branch used for WordPress releases. Goal is to update with wp/6.4 branch https://github.com/wordpress/gutenberg/tree/wp/6.4

Known issues to be addressed

✅ Reusable blocks are now synced patterns https://wordpress.org/news/2023/07/synced-patterns-the-evolution-of-reus....
Check implications other the name change.
#3402975: Patterns and synced patterns (reusable blocks)
✅ Editor's header container has changed. Find a way to append node form's action buttons.
✅ Duotone filter server script refactored. Port new code to module.
https://git.drupalcode.org/project/gutenberg/-/commit/95b352017f43757e52...
#3402860: Duotone processor: Handle duotone theme presets
✅ Extend default configuration for editor. Sections like styles are no longer available by default. Review and fix default configuration.
✅ Check the new Media tab at block inserter. Either use it or remove it
#3402804: New Media tab at block inserter
✅ Review all core blocks. There's new ones specific to WP that will be unusable in Drupal.
#3402817: Override registerCoreBlocks()
✅ Review the new lock mechanism. Adapt to Drupal. - There's no additional integration with roles/permissions yet.
#3404131: Add manage blocks lock permission
✅ Small adjustments to admin style.
✅ Styles and images not loading when previewing tablet and phone modes
#3404152: Styles and images not loading when previewing tablet and phone modes
✅ Generate spacing preset sizes as CSS variables
#3423779: Generate spacing sizes CSS variables
✅ Remove "Use featured image" option from blocks like Cover #3423823: Remove "Use featured image" option from blocks like Cover

Other tasks

✅ Merge 8.x-2.x branch
Change client script and style build. Embrace ES6. Already supported by all browsers. Add esbuild to compile JSX. Keep drupal-js-build only for CSS (for now). Check for the packages approach done in WP and also here https://git.drupalcode.org/project/decoupled_lb
#3402949: Remove ES5 compiling. Add JSX compiling.
#3403222: Move the vendor folder to a different name

Issue fork gutenberg-3334499

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3334499-update-gutenberg-library changes, plain diff MR !94
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

18 January 2023 at 10:53

marcofernandes created an issue. See original summary.

Comment #2

marcofernandes commented 18 November 2023 at 22:03

Issue summary:

View changes

Comment #3

marcofernandes commented 18 November 2023 at 22:03

Issue summary:

View changes

Comment #4

18 November 2023 at 22:58

marcofernandes committed dd8efb2b on 3.0.x

Issue #3334499 fix: Temporary fix for missing node form action buttons

Comment #5

18 November 2023 at 22:58

marcofernandes committed 3391e2a4 on 3.0.x

Issue #3334499 fix: Add missing properties when loading synced patterns...

Comment #6

18 November 2023 at 22:58

marcofernandes committed 98b61076 on 3.0.x

Issue #3334499: Remove Bartik and Seven related styles; Update compiled...

Comment #7

marcofernandes commented 18 November 2023 at 23:04

Issue summary:

View changes

Comment #8

marcofernandes commented 20 November 2023 at 09:20

Issue summary:

View changes

Comment #9

20 November 2023 at 10:44

marcofernandes committed 95b35201 on 3.0.x

Issue #3334499 by marcofernandes: Fix duotone processor

Comment #10

marcofernandes commented 20 November 2023 at 10:45

Issue summary:

View changes

Comment #11

marcofernandes commented 20 November 2023 at 11:15

Issue summary:

View changes

Comment #12

marcofernandes commented 20 November 2023 at 11:19

Issue summary:

View changes

Comment #13

marcofernandes commented 20 November 2023 at 11:27

Issue summary:

View changes

Comment #14

marcofernandes commented 20 November 2023 at 14:27

Issue summary:

View changes

Comment #15

marcofernandes commented 20 November 2023 at 21:23

Issue summary:

View changes

Comment #16

marcofernandes commented 21 November 2023 at 00:36

Issue summary:

View changes

Comment #17

marcofernandes commented 21 November 2023 at 08:43

Issue summary:

View changes

Comment #18

21 November 2023 at 22:44

marcofernandes committed 33bb7a2d on 3.0.x

Issue #3334499 by marcofernandes: Move vendor directory

Comment #19

marcofernandes commented 22 November 2023 at 08:44

Issue summary:

View changes

Comment #20

marcofernandes commented 22 November 2023 at 08:58

Issue summary:

View changes

Comment #21

22 November 2023 at 16:26

marcofernandes committed fe9bf4d2 on 3.0.x

Issue #3334499 by marcofernandes: Fix Claro lib loading

Comment #22

22 November 2023 at 17:35

marcofernandes committed 1c7228d6 on 3.0.x

Issue #3334499 by marcofernandes: Fix flickering when transitioning from...

Comment #23

22 November 2023 at 17:35

marcofernandes committed 0e24bb95 on 3.0.x

Issue #3334499 by marcofernandes: Enable view mode

Comment #24

22 November 2023 at 17:35

marcofernandes committed 94e5099c on 3.0.x

Issue #3334499 by marcofernandes: Improve behaviour when clicking More...

Comment #25

marcofernandes commented 22 November 2023 at 17:41

Issue summary:	View changes
Status:	Active	» Needs review

Enough done for a beta or RC release for initial tests.
Next step is to review all issues on 2.x that are ready to commit, review and fix critical issues (and some major) and merge into 3.0.x.

Comment #26

25 November 2023 at 01:52

marcofernandes committed 96a5a641 on 3.0.x

Issue #3334499 by marcofernandes: fetch API changed a bit for media...

Comment #27

25 November 2023 at 01:55

marcofernandes committed 8ff147fb on 3.0.x

Issue #3334499 by marcofernandes: Misc fixes

Comment #28

25 November 2023 at 13:25

marcofernandes committed fad44679 on 3.0.x

Issue #3334499 by marcofernandes: Code cleanup

Comment #29

25 November 2023 at 13:25

marcofernandes committed 571f797a on 3.0.x

Issue #3334499 by marcofernandes: Olivero support improvements

Comment #30

25 November 2023 at 13:25

marcofernandes committed f537c189 on 3.0.x

Issue #3334499 by marcofernandes: Hide format select

Comment #31

marcofernandes commented 25 November 2023 at 17:33

Issue summary:	View changes
Status:	Needs review	» Needs work

Comment #32

marcofernandes commented 25 November 2023 at 17:35

Issue summary:

View changes

Comment #33

26 November 2023 at 21:07

marcofernandes committed f65a5da7 on 3.0.x

Issue #3334499 by marcofernandes: Update Gutenberg library - update...

Comment #34

26 November 2023 at 21:07

marcofernandes committed c604f0c7 on 3.0.x

Issue #3334499 by marcofernandes: Update Gutenberg library

Comment #35

marcofernandes commented 26 November 2023 at 21:18

Issue summary:	View changes
Status:	Needs work	» Needs review

Comment #36

3 December 2023 at 23:16

marcofernandes committed 7d5d89be on 3.0.x

Issue #3334499 by marcofernandes: Update Gutenberg library

Comment #37

codebymikey commented 16 January 2024 at 18:36

The 94e5099c9 commit currently affects integrations with long grouped fields within the More Settings such as Details and Select boxes, attempting to click one of them automatically scrolls the user back to the top of the Additional Fields section, which isn't expected behaviour.

Also, is there a reason we opted to handle this in PHP via:

'onclick' => 'moreSettingsClick(this);',

rather than a dynamic toggle event listener targetting the more settings class?

I would opt to remove the event listener to reduce code complexity unless the existing behaviour expand/collapase behaviour is unmanageable under certain themes. If so, I believe the following should achieve the same work without breaking things:

$('details.more-settings', context).on('toggle', function () {
  if (this.open) {
    this.scrollIntoView({
      behavior: 'smooth',
      block: 'start',
      inline: 'nearest',
    });
  }
});

Otherwise, I think we're better off leaving these admin-specific UI changes to the admin theme or individual site developers to implement as they deem fit to avoid complications.

Also, is there a reason we opted to handle this in PHP

No reason at all 😁 and since it's causing that bad behavior, it should be moved to the client script has you suggested.

Comment #41

25 January 2024 at 22:59

marcofernandes committed 47abcacd on 3.0.x authored by codebymikey

Issue #3334499: Update more settings onclick/toggle listener

Comment #42

marcofernandes commented 26 February 2024 at 11:27

Issue summary:

View changes

Comment #43

marcofernandes commented 26 February 2024 at 13:10

Issue summary:

View changes

Comment #44

16 April 2024 at 08:46

marcofernandes committed d57f0b9f on 3.0.x

Issue #3334499: Adjust media dialog z-index.

Comment #45

7 May 2024 at 10:28

marcofernandes committed d3acbb2b on 3.0.x

Issue #3334499: Add CSS for border colors

Needs review

» Fixed

Comment #50

6 July 2024 at 15:48

marcofernandes committed d3acbb2b on 4.0.x

Issue #3334499: Add CSS for border colors

Comment #51

20 July 2024 at 15:49

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Update Gutenberg library

Known issues to be addressed

Other tasks

Issue fork gutenberg-3334499

Comments

Parent issue

Child issues

Referenced by