With throttle disabled by default, the link in admin/modules to the "throttle configuration page" shouldn't be there.

CommentFileSizeAuthor
#9 system_throttle_0.patch3.29 KBChrisKennedy
#6 system_throttle.patch3.28 KBChrisKennedy
#4 system.module_32.patch3.02 KBwulff
#1 system.module_25.patch2.39 KBwulff
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

wulff’s picture

wulff CreditAttribution: wulff commented
FileSize
system.module_25.patch2.39 KB

Attached patch changes behavior so the link is only displayed when the throttle module is enabled.

wulff’s picture

wulff CreditAttribution: wulff commented
Status: Active » Needs review
Heine’s picture

Heine CreditAttribution: Heine commented
Status: Needs review » Needs work

no longer applies against head (5 sept)

wulff’s picture

wulff CreditAttribution: wulff commented
FileSize
system.module_32.patch3.02 KB

Rerolled patch attached. An alternative to the solution in the patch (removing a sentence) would be to just remove the link.

Heine’s picture

Heine CreditAttribution: Heine commented
Status: Needs work » Needs review
ChrisKennedy’s picture

ChrisKennedy CreditAttribution: ChrisKennedy commented
Title: Admin/modules links to "throttle configuration page" even when it is disabled » String freeze: Admin/modules links to "throttle configuration page" even when it is disabled
Version: x.y.z » 5.x-dev
FileSize
system_throttle.patch3.28 KB

Re-integrated into DRUPAL-5 cvs. I also took out "Click on the name of the module in the navigation menu for their individual configuration pages." as it is no longer relevant with the overhaul of the administrative interface. Flagging for the string freeze.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Version: 5.x-dev » 6.x-dev
Zen’s picture

Zen CreditAttribution: Zen commented
Status: Needs review » Reviewed & tested by the community

Patch still applies with an offset.

ChrisKennedy’s picture

ChrisKennedy CreditAttribution: ChrisKennedy commented
Title: String freeze: Admin/modules links to "throttle configuration page" even when it is disabled » Admin/modules links to "throttle configuration page" even when it is disabled
FileSize
system_throttle_0.patch3.29 KB

Fixed the string concatenation error and removed the initial space from the translated string.

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented

This works as advertised, however, I am not sure that anybody will see the new text after the module got enabled. Shouldn't this be part of a drupal_set_message in an install hook? Maybe even in addition to the existing text.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Needs review

I've committed the patch for now, but we can reconsider this if we want. I'll mark it as 'code needs review'.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Fixed

Since no-one argued against the commit for five months, I'm setting this to fixed.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.