Problem/Motivation

To make it easier for other developers to contribute code, let's update Simple OAuth to follow the Drupal coding standards.

Proposed resolution

Update the code to follow Drupal coding standards

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork simple_oauth-3330328

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

idebr created an issue. See original summary.

idebr opened merge request !85

idebr’s picture

idebr CreditAttribution: idebr at iO commented
Status: Active » Needs review

The merge request updates the code to follow Drupal coding standards.

sourabhjain’s picture

sourabhjain
Primary language English
CreditAttribution: sourabhjain at Valuebound for Valuebound commented
Assigned: Unassigned » sourabhjain

I will review this PR

sourabhjain’s picture

sourabhjain
Primary language English
CreditAttribution: sourabhjain at Valuebound for Valuebound commented
Assigned: sourabhjain » Unassigned
Status: Needs review » Needs work

Fixed some coding standard issues but still some are remaining

sourabhjain@LPT-SOURABH simple_oauth % phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

FILE: /Users/sourabhjain/www/drupal/modules/contrib/simple_oauth/tests/modules/simple_oauth_test/simple_oauth_test.routing.yml
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
 8 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/sourabhjain/www/drupal/modules/contrib/simple_oauth/simple_oauth.routing.yml
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------
 48 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
 57 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
------------------------------------------------------------------------------------------------------------------


FILE: /Users/sourabhjain/www/drupal/modules/contrib/simple_oauth/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------
 18 | WARNING | Line exceeds 80 characters; contains 116 characters
 25 | WARNING | Line exceeds 80 characters; contains 115 characters
 26 | WARNING | Line exceeds 80 characters; contains 175 characters
 27 | WARNING | Line exceeds 80 characters; contains 207 characters
 29 | WARNING | Line exceeds 80 characters; contains 117 characters
 30 | WARNING | Line exceeds 80 characters; contains 106 characters
 34 | WARNING | Line exceeds 80 characters; contains 312 characters
 42 | WARNING | Line exceeds 80 characters; contains 403 characters
 46 | WARNING | Line exceeds 80 characters; contains 474 characters
--------------------------------------------------------------------------


FILE: /Users/sourabhjain/www/drupal/modules/contrib/simple_oauth/modules/simple_oauth_static_scope/README.md
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------
  3 | WARNING | Line exceeds 80 characters; contains 110 characters
  5 | WARNING | Line exceeds 80 characters; contains 117 characters
  7 | WARNING | Line exceeds 80 characters; contains 124 characters
 19 | WARNING | Line exceeds 80 characters; contains 82 characters
 20 | WARNING | Line exceeds 80 characters; contains 87 characters
 24 | WARNING | Line exceeds 80 characters; contains 108 characters
------------------------------------------------------------------------------------------------------------


FILE: /Users/sourabhjain/www/drupal/modules/contrib/simple_oauth/src/Service/Filesystem/FileSystemCheckerInterface.php
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
 70 | ERROR | Unknown type hint "mixed" found for $data
----------------------------------------------------------------------------------------------------------------------


FILE: /Users/sourabhjain/www/drupal/modules/contrib/simple_oauth/src/Entities/ScopeEntity.php
-----------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------
 36 | ERROR | Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead
 41 | ERROR | Doc comment is empty
-----------------------------------------------------------------------------------------------------
idebr’s picture

idebr CreditAttribution: idebr at iO commented
Status: Needs work » Needs review

Let's limit the issue scope to Drupal coding standards and not DrupalPractice to keep the required changes to a minimum.

bojan_dev’s picture

bojan_dev CreditAttribution: bojan_dev commented
Status: Needs review » Needs work
idebr’s picture

idebr CreditAttribution: idebr at iO commented
Status: Needs work » Needs review

  • bojan_dev committed ffe2c0b6 on 6.0.x authored by idebr 
    Issue #3330328: Update code to follow Drupal coding standards
bojan_dev’s picture

bojan_dev CreditAttribution: bojan_dev commented
Status: Needs review » Fixed
bojan_dev’s picture

bojan_dev CreditAttribution: bojan_dev commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.