On a site that's using 'migrate' but not 'migrate_plus', I'm getting this error:
Error: Class "Drupal\migrate_plus\Entity\MigrationGroup" not found in Drupal\inline_entity_form\MigrationHelper->getMigrationWithSharedConfiguration() (line 155 of /app/web/modules/contrib/inline_entity_form/src/MigrationHelper.php) #0 /app/web/modules/contrib/inline_entity_form/src/MigrationHelper.php(34): Drupal\inline_entity_form\MigrationHelper->getMigrationWithSharedConfiguration(Array)
Checking that the class exists before trying to call the load() method fixes it in my testing!
I'll attach a patch in a moment.
| Comment | File | Size | Author |
|---|
Issue fork inline_entity_form-3325698
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
dsnopekHere's the patch! Please let me know what you think :-)
Comment #3
geek-merlinHmm, how did the 'migrate_group' key get in in the first place without migrate_plus?
But maybe that's an academic question, so don't care.
I suppose the patch fixes the issue for you?
Code-wise it's trivial and makes sense.
Setting RTBC.
Can you can add a MR?
Comment #5
podaroktnx
Comment #7
geek-merlinBulk reopen.
Comment #10
dcam commentedConverted the patch into an MR as requested in #3.
There are so many migration examples out there that require Migrate Plus whether it's needed or not. I'm certain that someone could easily copy a migration YAML file that contains a
migrate_groupkey and not realize what they've done. I've done it before.Fortunately I caught it during a code review.
I tried to think of what I'd do differently here, if anything. But I think this is OK as it is. Don't feel like you need to credit me for this. I didn't do anything worth mentioning.
Comment #11
geek-merlinThx a bunch! So let's get this trival thing in!
Comment #12
geek-merlin