Problem/Motivation

Currently the maximum number of webforms per page on the webform admin overview page is 50. Would it be ok to increase this limit?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 after.png164.51 KBgaurav-mathur
#3 before.png170.74 KBgaurav-mathur
#2 3325234-increase-number-of-webforms.patch617 bytesBandana
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Bandana created an issue. See original summary.

Bandana’s picture

Bandana CreditAttribution: Bandana as a volunteer commented
Status: Active » Needs review
FileSize
3325234-increase-number-of-webforms.patch617 bytes
gaurav-mathur’s picture

gaurav-mathur CreditAttribution: gaurav-mathur at Dotsquares Ltd. commented
FileSize
before.png170.74 KB
after.png164.51 KB

Applied patch #2 working fine ,refer to the screenshot

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at Webform module Open Collective, The Big Blue House commented
Version: 6.2.x-dev » 6.1.x-dev

The risk of increasing the page size is running out of PHP memory.

Bandana’s picture

Bandana CreditAttribution: Bandana as a volunteer commented

After some (biased) testing I do indeed run into memory issues. I imported 200 webforms (.yml size ~ 30kb) to a fairly fresh drupal install.. php memory limits:

32M => Site status page doesnt load.
64M => Site status page loads after cache clear, webform overview loads with 100 per page but exhausts memory with 150 per page. If 100 results is configured, overview page visited, results is changed to 150 without cache clear in between it loads 150 without issues.
128M => Site status page loads after cache clear, loads 150 without issues but if visiting webforms overview page as first page after cache clear with 150 results configured it exhausts memory
256M => no issues

Would it make sense to show a notice to admins that configure the higher amount of results? It's quite a timesaver having the option to show more results per page when developing.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at Webform module Open Collective, The Big Blue House commented
Status: Needs review » Reviewed & tested by the community

Based on #5 maybe we should just double the allowed amount to 100.

PHP Memory: the minimum memory size of 64MB

@see https://www.drupal.org/docs/system-requirements/overview

  • 6d70771 committed on 6.1.x 
    Issue #3325234 by Bandana: Increase number of webforms per page on...

  • 6d70771 committed on 6.x 
    Issue #3325234 by Bandana: Increase number of webforms per page on...

  • 6d70771 committed on 6.2.x 
    Issue #3325234 by Bandana: Increase number of webforms per page on...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at Webform module Open Collective, The Big Blue House commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.