Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Currently there are several JavaScript files in different libraries of Gin that make use of the drupalSettings
variable. Unfortunately these libraries do not declare their core/drupalSettings
dependency, which may cause JavaScript errors in certain circumstances - e.g. when no other library on a page requires the core/drupalSettings
library as well.
Steps to reproduce
Create a page where only Gin's libraries are loaded, but not core/drupalSettings
directly
Proposed resolution
- Correctly declare library dependencies to
core/drupalSettings
ingin.libraries.yml
Remaining tasks
- Create patch / issue fork to fix the issue
User interface changes
n/a
API changes
n/a
Data model changes
n/a
Issue fork gin-3323066
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
hctomThe issue fork should now provide all relevant
core/drupalSettings
dependencies for corresponding Gin libraries.Comment #5
saschaeggiThanks hctom!