Problem/Motivation

Currently there are several JavaScript files in different libraries of Gin that make use of the drupalSettings variable. Unfortunately these libraries do not declare their core/drupalSettings dependency, which may cause JavaScript errors in certain circumstances - e.g. when no other library on a page requires the core/drupalSettings library as well.

Steps to reproduce

Create a page where only Gin's libraries are loaded, but not core/drupalSettings directly

Proposed resolution

  • Correctly declare library dependencies to core/drupalSettings in gin.libraries.yml

Remaining tasks

  • Create patch / issue fork to fix the issue

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Issue fork gin-3323066

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hctom created an issue. See original summary.

hctom’s picture

Assigned: hctom » Unassigned
Status: Active » Needs review

The issue fork should now provide all relevant core/drupalSettings dependencies for corresponding Gin libraries.

  • saschaeggi committed 6334bbf on 8.x-3.x authored by hctom
    Issue #3323066: Correctly declare library dependencies to core/...
saschaeggi’s picture

Status: Needs review » Fixed

Thanks hctom!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.