Problem/Motivation

Now generated css files contain wrong indent in some places, here is an example:

@media (min-width: 48em) {
  .toolbar-tray-open:not(.toolbar-vertical) .layout-container,
body:not(.toolbar-tray-open) .layout-container {
    margin-left: var(--gin-spacing-xl);
    margin-right: var(--gin-spacing-xl);
  }
}

The right indent should be like this:

@media (min-width: 48em) {
  .toolbar-tray-open:not(.toolbar-vertical) .layout-container,
  body:not(.toolbar-tray-open) .layout-container {
    margin-left: var(--gin-spacing-xl);
    margin-right: var(--gin-spacing-xl);
  }
}

And if I regenerate css via yarn build - all indents comes to normal.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork gin-3322187

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Murz created an issue. See original summary.

Murz opened merge request !198

Murz’s picture

Murz
Primary language English
Location Yerevan, Armenia
CreditAttribution: Murz as a volunteer and at EPAM Systems for TVH commented
Status: Active » Needs review

I've created an MR with fixes for indents, please review.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer commented
Status: Needs review » Postponed (maintainer needs more info)

@Murz this won't work as the next time we compile it will be changed again.

Murz’s picture

Murz
Primary language English
Location Yerevan, Armenia
CreditAttribution: Murz as a volunteer and at EPAM Systems for TVH commented

But I've just compiled them using yarn install; yarn build command and they become normal. Why should the next compilation break them back?

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer commented

We use npm and not yarn for this project, see README. With the given environment I don't see any changes.

So the "issue" might be caused by different packages versions.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer commented

If you can figure out which packages we need to update to fix this, I'm happy to merge.

Murz’s picture

Murz
Primary language English
Location Yerevan, Armenia
CreditAttribution: Murz as a volunteer and at EPAM Systems for TVH commented

Yeah, for npm lock file contains old version of sass module, updating it resolves the problem! I've updated my MR.

  • saschaeggi committed aa1c43c on 8.x-3.x authored by Murz 
    Issue #3322187: Fix indents in generated css files
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer commented
Status: Postponed (maintainer needs more info) » Fixed

Great, thanks @Murz!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.