Problem/Motivation

new release of CKE5 https://github.com/ckeditor/ckeditor5/releases/tag/v35.3.1

yarn build
yarn build:ckeditor5-types

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#14 3321191-14-d94.patch1.34 MBSpokje
#11 3321191-11-9.5.x.patch1.33 MBlongwave
#5 core-3321191-3-9.5.x.patch1.33 MBnod_
#3 core-3321191-3-10.x.patch1.33 MBnod_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_ created an issue. See original summary.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Parent issue: » #3258933: [meta] Update JavaScript dependencies for Drupal 10
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Status: Active » Needs review
FileSize
core-3321191-3-10.x.patch1.33 MB
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

I get the same changes locally, tests pass -> RTBC.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
FileSize
core-3321191-3-9.5.x.patch1.33 MB
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

CKEditor 5 changes are identical in both branches, the interdiff between the two patches is only in package.json and yarn.lock, therefore assuming tests pass this is also RTBC on 9.5.x.

  • catch committed e65e8c4 on 10.1.x 
    Issue #3321191 by nod_, longwave: update ckeditor5 to v35.3.1

  • catch committed 23f7001 on 10.0.x 
    Issue #3321191 by nod_, longwave: update ckeditor5 to v35.3.1

(cherry...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 10.1.x-dev » 9.5.x-dev
Issue tags: +9.5.0 release notes

10.1/10.0 is in, waiting for the test run on 9.5.

Do we want this in 9.4.x too?

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

Yes, we should backport this to 9.4.x as there should be a final patch release in December before 9.5.0.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
FileSize
3321191-11-9.5.x.patch1.33 MB

Rerolled #5, just patch fuzz:

$ curl -s https://www.drupal.org/files/issues/2022-11-14/core-3321191-3-9.5.x.patch | patch -p1
patching file core/assets/vendor/ckeditor5/ckeditor5-dll/ckeditor5-dll.js
patching file core/core.libraries.yml
patching file core/package.json
patching file core/yarn.lock
Hunk #1 succeeded at 911 with fuzz 1 (offset -55 lines).
Hunk #2 succeeded at 2339 (offset -72 lines).

  • catch committed fdabe37 on 9.5.x 
    Issue #3321191 by nod_, longwave: update ckeditor5 to v35.3.1
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.5.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Needs work

Committed fdabe37 and pushed to 9.5.x. Thanks!

Leaving open for backport to 9.4

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
FileSize
3321191-14-d94.patch1.34 MB
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Status: Needs work » Needs review
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Status: Needs review » Reviewed & tested by the community

  • catch committed dbaa5e8 on 9.4.x 
    Issue #3321191 by nod_, longwave, Spokje: update ckeditor5 to v35.3.1
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +9.4.9 release notes

Committed/pushed to 9.4.x, thanks!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Related issues: +#3318867: Update CKEditor 5 to 35.3.0

Yay!

Previous update was #3318867: Update CKEditor 5 to 35.3.0.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.