Problem/Motivation

When using the 'Select' widget provided by the 'Webform'-module, the entity reference selection plugin that is selected, isn't taken into account.
This issue has been fixed on the 5.x branch (see #3133393: Select widget of webform field doesn't use its entity reference selection plugin), but seems to be removed from 6.2.0 (I'm currently using 6.2.0-beta3).

Steps to reproduce

  1. Create custom EntityReferenceSelection for 'Webform' entity type
  2. Create new field of type Entity reference: Webform
  3. Select your custom EntityReferenceSelection as the Reference method
  4. Make sure Select list is selected as the widget on the Form display page

The functionality of your custom EntityReferenceSelection won't be triggered.

Proposed resolution

I've re-rolled the patch of #3133393: Select widget of webform field doesn't use its entity reference selection plugin, so it can be applied on the 6.2.x branch. When applying this patch, the functionality of my EntityReferenceSelection is being triggered.

CommentFileSizeAuthor
#6 3320015-6.patch1.24 KBjrockowitz
#5 3320015-5.patch1.24 KBjrockowitz
#2 3320015-2.patch1.26 KBmichaelsoetaert

Issue fork webform-3320015

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

michaelsoetaert created an issue. See original summary.

michaelsoetaert’s picture

michaelsoetaert
Primary language Dutch
Location Belgium 🇧🇪
CreditAttribution: michaelsoetaert as a volunteer commented
FileSize
3320015-2.patch1.26 KB
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at Webform module Open Collective, The Big Blue House commented
Status: Active » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3320015-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at Webform module Open Collective, The Big Blue House commented
Status: Needs work » Needs review
FileSize
3320015-5.patch1.24 KB
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at Webform module Open Collective, The Big Blue House commented
FileSize
3320015-6.patch1.24 KB

himanshu_jhaloya made their first commit to this issue’s fork.

himanshu_jhaloya’s picture

himanshu_jhaloya CreditAttribution: himanshu_jhaloya at Valuebound for Valuebound commented
Assigned: Unassigned » himanshu_jhaloya

I will review the patch

himanshu_jhaloya’s picture

himanshu_jhaloya CreditAttribution: himanshu_jhaloya at Valuebound for Valuebound commented
Assigned: himanshu_jhaloya » Unassigned
michaelsoetaert’s picture

michaelsoetaert
Primary language Dutch
Location Belgium 🇧🇪
CreditAttribution: michaelsoetaert as a volunteer commented

I've tested patch #6 and everything seems to work as expected.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at Webform module Open Collective, The Big Blue House commented
Status: Needs review » Reviewed & tested by the community

  • jrockowitz authored ac29b3ef on 6.1.x 
    Issue #3320015 by jrockowitz, michaelsoetaert, himanshu_jhaloya: Select...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at Webform module Open Collective, The Big Blue House commented
Status: Reviewed & tested by the community » Fixed

  • jrockowitz authored ac29b3ef on 6.x 
    Issue #3320015 by jrockowitz, michaelsoetaert, himanshu_jhaloya: Select...

  • jrockowitz authored ac29b3ef on 6.2.x 
    Issue #3320015 by jrockowitz, michaelsoetaert, himanshu_jhaloya: Select...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.