Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
CKEditor 5 35.3.0 is out: https://github.com/ckeditor/ckeditor5/releases/tag/v35.3.0
Steps to reproduce
Proposed resolution
- Update
core/package.json
cd core
yarn install
yarn build
yarn build:ckeditor5-types
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
The version of CKEditor 5 has been updated from 35.2.1 to 35.3.0.
Comment | File | Size | Author |
---|---|---|---|
#9 | 3318867-9-10.x.patch | 1.96 MB | longwave |
| |||
#9 | 3318867-9-9.4.x.patch | 1.96 MB | longwave |
#7 | interdiff.txt | 1.29 KB | lauriii |
#7 | 3318867-7-95x.patch | 1.96 MB | lauriii |
Comments
Comment #2
longwaveComment #3
longwaveThis seems likely to be the version that we ship with 9.5.0 and 10.0.0, given that the next CKEditor 5 iteration is released on December 13, and we plan to release on December 14; that probably doesn't leave us enough time.
Comment #6
Wim Leershttps://github.com/ckeditor/ckeditor5/releases/tag/v35.3.0 has various mentions of "table caption" — and it looks like they either broke this or we need to tweak our test.
Comment #7
lauriiiI don't think this was an actual regression. It seems like a problem with how the
\Drupal\Tests\ckeditor5\FunctionalJavascript\TableTest::testTableCaptionUi
tried to modify content within CKEditor 5.Comment #8
Wim LeersPerfect, that's what I thought/hoped! 😊
Now we just need the same fix to be applied to the 9.4 and 10.0/10.1 patches and we're good to go! 👍
Comment #9
longwave#2 with interdiff from #7 applied.
Comment #10
Wim LeersLooking great! 🤩
Comment #11
alexpottCommitted and pushed b5208e2855 to 10.1.x and 4f7315fd4b to 10.0.x. Thanks!
Committed fedcff2 and pushed to 9.5.x. Thanks!
Committed c136ca7 and pushed to 9.4.x. Thanks!
Comment #17
longwave