Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#18 | interdiff.3317887.10-18.txt | 1.19 KB | longwave |
#18 | 3317887-18-9.5.x.patch | 13.01 KB | longwave |
#18 | 3317887-18-10.x.patch | 868 bytes | longwave |
| |||
#10 | core-3317887-10-9.5.x.patch | 13.05 KB | nod_ |
#6 | core-3317887-6-9.5.x.patch | 15.86 KB | nod_ |
Comments
Comment #2
longwaveComment #3
longwavePatch for 9.5.x.
Comment #4
nod_There was a release for postcss-header yesterday. It's a patch release so not a big deal.
Comment #5
catchNeeds a re-roll anyway.
Comment #6
nod_updated
yarn upgrade postcss postcss-header postcss-preset-env
Comment #7
nod_Comment #8
nod_umm not sure how to solve the problem in 9.5 properly, there are other dependencies that would be better to update in 9.5 instead of those. so let's just not update that 9.5 ?
Comment #9
effulgentsia CreditAttribution: effulgentsia at Acquia commentedThese are the only lines that are in addition to the
yarn upgrade postcss postcss-header postcss-preset-env
command, and according to https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-color, these haven't been necessary since Safari 12.2.Given that there are other 9.5 dependencies that are preventing upgrading postcss, I think we could investigate what, if anything, we want to update for 9.5 in a follow-up.
Therefore, RTBC for the Drupal 10 patch.
Comment #10
nod_Got a 9.5.x patch working
Comment #12
lauriiiCommitted 7143315 and pushed to 10.1.x and cherry-picked to 10.0.x. Thanks!
Leaving open against 9.5.x.
Comment #14
catchThis looks a bit odd in the 9.5 patch?
Comment #15
lauriiiIt does look odd but I'm not particularly concerned about that because the comment ends before the ruleset, and it's in the generated CSS.
Comment #16
longwaveLooks like PostCSS 8.4.19 (released today) might fix this? Appears to be the same issue described at https://github.com/postcss/postcss/issues/1785
Comment #17
longwaveComment #18
longwaveBumped to PostCSS 8.4.19 - this fixes #14 in 9.5.x, it makes no difference in 10.x but we should be on the latest version anyway.
Comment #19
nod_Comment #20
catchCommitted/pushed to 10.1.x/10.0.x/9.5.x respectively thanks!