Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

Status: Active » Needs review
FileSize
12.44 KB
longwave’s picture

Patch for 9.5.x.

nod_’s picture

Status: Needs review » Reviewed & tested by the community

There was a release for postcss-header yesterday. It's a patch release so not a big deal.

catch’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs a re-roll anyway.

nod_’s picture

updated yarn upgrade postcss postcss-header postcss-preset-env

nod_’s picture

Title: Update PostCSS and postcss-preset-env » Update PostCSS, postcss-header, and postcss-preset-env
nod_’s picture

umm not sure how to solve the problem in 9.5 properly, there are other dependencies that would be better to update in 9.5 instead of those. so let's just not update that 9.5 ?

effulgentsia’s picture

Status: Needs review » Reviewed & tested by the community
+++ b/core/themes/olivero/css/components/text-content.css
@@ -42,7 +42,6 @@
-  -webkit-text-decoration-color: currentColor;
@@ -62,7 +61,6 @@
-    -webkit-text-decoration-color: var(--color--primary-80);

These are the only lines that are in addition to the yarn upgrade postcss postcss-header postcss-preset-env command, and according to https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-color, these haven't been necessary since Safari 12.2.

Given that there are other 9.5 dependencies that are preventing upgrading postcss, I think we could investigate what, if anything, we want to update for 9.5 in a follow-up.

Therefore, RTBC for the Drupal 10 patch.

nod_’s picture

Got a 9.5.x patch working

  • lauriii committed 7143315 on 10.1.x
    Issue #3317887 by nod_, longwave, effulgentsia: Update PostCSS, postcss-...
lauriii’s picture

Version: 10.0.x-dev » 9.5.x-dev

Committed 7143315 and pushed to 10.1.x and cherry-picked to 10.0.x. Thanks!

Leaving open against 9.5.x.

  • lauriii committed 68c74c0 on 10.0.x
    Issue #3317887 by nod_, longwave, effulgentsia: Update PostCSS, postcss-...
catch’s picture

diff --git a/core/themes/olivero/css/components/tabs.css b/core/themes/olivero/css/components/tabs.css
index 0ac9a61b2b..ce656af52d 100644
--- a/core/themes/olivero/css/components/tabs.css
+++ b/core/themes/olivero/css/components/tabs.css
@@ -3,8 +3,7 @@
  * See the following change record for more information,
  * https://www.drupal.org/node/3084859
  * @preserve
- */
-[dir="ltr"] .tabs {
+ */[dir="ltr"] .tabs {
   margin-left: 0;
 }

This looks a bit odd in the 9.5 patch?

lauriii’s picture

It does look odd but I'm not particularly concerned about that because the comment ends before the ruleset, and it's in the generated CSS.

longwave’s picture

Status: Reviewed & tested by the community » Needs work

Looks like PostCSS 8.4.19 (released today) might fix this? Appears to be the same issue described at https://github.com/postcss/postcss/issues/1785

longwave’s picture

longwave’s picture

Status: Needs work » Needs review
FileSize
868 bytes
13.01 KB
1.19 KB

Bumped to PostCSS 8.4.19 - this fixes #14 in 9.5.x, it makes no difference in 10.x but we should be on the latest version anyway.

nod_’s picture

Status: Needs review » Reviewed & tested by the community
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x/10.0.x/9.5.x respectively thanks!

  • catch committed 836bf12 on 10.0.x
    Issue #3317887 by longwave, nod_, lauriii, effulgentsia: Update PostCSS...
  • catch committed 1d58e2b on 10.1.x
    Issue #3317887 by longwave, nod_, lauriii, effulgentsia: Update PostCSS...
  • catch committed d9cb42c on 9.5.x
    Issue #3317887 by longwave, nod_, lauriii, effulgentsia: Update PostCSS...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.