Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
We need to remove php-http/guzzle6-adapter from our dependencies and allow guzzlehttp/guzzle ^6 || ^7.
3.1.x has the adapter, but it is not used. 3.x leverages the adapter.
Steps to reproduce
Proposed resolution
1.Remove dependency on php-http/guzzle6-adapter in composer.json'
2. Remove \Drupal\acquia_search\Client\Adapter\TimeoutAwarePsr18Adapter
3. \Drupal\acquia_search\Plugin\SolrConnector\SearchApiSolrAcquiaConnector::connect should rely on {{$this->createClient()}} like parent and not construct its own adapter
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork acquia_search-3316883
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3316883-remove-usage-of
changes, plain diff MR !9
1 hidden branch
Comments
Comment #3
nkoporecComment #4
mglamanI'm pretty sure the adapter was added to work around #3198150: Curl adapter doesn't respect the configured timeout. Which is in 4.1.12 and 4.2.x, which is our minimum for 3.x
Comment #5
mglamanPrefixing with branch, since we need a 3.1.x as well.
Comment #7
mglamanThanks, @nkoporec!