Problem/Motivation

The current OTP library while fully working is not as popular as other PHP OTP packages, and as such it can eventually become a maintenance issue. By switching to spomky-labs/otphp, the module will be able to leverage a much more popular PHP OTP library, which will hopefully have less potential bugs and be more secure because of that.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Issue fork tfa-3314264

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jcnventura created an issue. See original summary.

jcnventura’s picture

jcnventura
Primary language English
commented
Version: 8.x-1.x-dev » 2.x-dev

cmlara made their first commit to this issue’s fork.

cmlara opened merge request !66

cmlara’s picture

cmlara
he/him
commented
Issue summary: View changes
Status: Active » Needs review

Setting NR.

Only caveats I might have at the moment is the plugin notice in requirements refers to check the README for install instructions and there is no specific details. I see this as a separate bug itself on documentation and we can handle it in a followup issue to cleanup the documentation in general, perhaps in #3410085: Add support for Gitlab Pages and move some data from README.

cmlara’s picture

cmlara
he/him
commented
Status: Needs review » Fixed

  • cmlara committed ac84ec20 on 2.x 
    Issue #3314264 by cmlara: Switch to spomky-labs/otphp

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.