When you have a date field in your profile (I have date of birth), you enter year, month and day, e.g. [1975] [06] [21]. But when you view a user's profile with the date completed, it is displayed as '1975-06-21 H:i'. The H:i shouldn't be there.

Kobus

CommentFileSizeAuthor
#9 profile-470-patch_0.diff590 bytesoadaeh
#4 profile-470-patch.diff669 bytesKobus
#1 profile_short-date.patch835 bytestostinni
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tostinni’s picture

tostinni CreditAttribution: tostinni commented
Status: Active » Needs review
FileSize
profile_short-date.patch835 bytes

This is a long know problem with Drupal, there's no short date only format...
Btw, I went through a very simple patch to strip out the hour from this format.

Kobus’s picture

Kobus CreditAttribution: Kobus commented

I have tested this code and it works 100% on Drupal 4.6. I will see if I have similar problems on 4.7 or whether this patch still applies.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Needs work

Does not apply against HEAD.

Kobus’s picture

Kobus CreditAttribution: Kobus commented
Version: 4.6.3 » 4.7.0-beta3
Assigned: Unassigned » Kobus
Status: Needs work » Needs review
FileSize
profile-470-patch.diff669 bytes

Patch attached against 4.7 beta 3.

Regards,

Kobus

oadaeh’s picture

oadaeh CreditAttribution: oadaeh commented

This patch worked fine for me (after I stripped the path information) and fixed the problem on a CVS tar file I downloaded 28-ish hours ago.

Also, this bug is a duplicate of this one:
http://drupal.org/node/41181

Kobus’s picture

Kobus CreditAttribution: Kobus commented

Thanks for the test, Oadae, but mine is not the duplicate ;-) Mine is the oldest of the two :-) *chuckle*.

I can't for the life of me figure out how to re-roll the patch without the path information. I am using gnuwin32 patch-utils and diff-utils. Anybody can help with this?

Kobus

oadaeh’s picture

oadaeh CreditAttribution: oadaeh commented

I can fix the patch for you later this evening, if no one else does it first.

Also, I think I must have been looking at the date of the last comment, which is why I thought this one was newer.

tostinni’s picture

tostinni CreditAttribution: tostinni commented

What's wrong with kobus path information ?

In fact I don't understand why patch didn't apply against 4.7beta3 as there were no change in the code ?
Dries can you explain what's wrong ?
Short date format still exists in system.module and still have time inside ?

oadaeh’s picture

oadaeh CreditAttribution: oadaeh commented
Status: Needs review » Reviewed & tested by the community
FileSize
profile-470-patch_0.diff590 bytes

Okay, here's my modification of Kobus' patch. The paths and extra carriage returns are stripped, but everything else should be as it was.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks.

Kobus’s picture

Kobus CreditAttribution: Kobus commented
Status: Fixed » Closed (fixed)

Thanks! Closing...