Problem/Motivation

ckeditor has been removed from the standard profile and replaced by ckeditor5 in #3271097: Replace CKEditor 4 with CKEditor 5 in the Standard profile and StandardTest.
We forgot to do the same in \Drupal\Tests\system\Functional\Common\NoJavaScriptAnonymousTest.

Marking this as critical since the parent issue #3270438: Remove CKEditor 4 from core is marked as such.

Steps to reproduce

Proposed resolution

Replace ckeditor with ckeditor5 in \Drupal\Tests\system\Functional\Common\NoJavaScriptAnonymousTest

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3306712

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Spokje created an issue. See original summary.

Spokje’s picture

Spokje’s picture

Spokje’s picture

Spokje’s picture

Status: Active » Needs review
Spokje’s picture

Title: Replace ckeditor with ckeditor5 in \Drupal\Tests\system\Functional\Common\NoJavaScriptAnonymousTest » Replace ckeditor with ckeditor5 in NoJavaScriptAnonymousTest
quietone’s picture

Status: Needs review » Reviewed & tested by the community

This change is also in the deprecation issue but it makes sense to remove an integration is a separate issue.

Spokje’s picture

Thanks @quietone, didn't notice it was in the deprecation issue, stumbled upon this whilst doing a test-run of the deletion issue.

Agreed that a separate issue will make it more clear and gives both issues a chance to get to RTBC independently.

Wim Leers’s picture

RTBC +1

This simplifies #3304326: Deprecate CKEditor 4 module in 9.5 slightly.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

This test is wrong... I've no idea why we're listing the modules used in standard in this way but it's bound to get out of sync. We should replace the module list and set the $profile property to standard and be done. Maybe this ability wasn't known when #2120457: Add test to guarantee that the Standard profile does not load any JavaScript for anonymous users on critical pages was written and reviewed.

Spokje’s picture

@alexpott This test _is_ wrong, I've already opened up #3306713: Refactor module array in NoJavaScriptAnonymousTest to burn it to the ground refactor it. (See #4, where I also state that this is the second time we/I fallen into this trap).

Not sure if we want to refactor the whole test in this issue and postpone ckeditor4/5 on this, personally I don't think so.
But fully agreeing that the test is wrong and needs to be refactored.

alexpott’s picture

So we need to add

  /**
   * {@inheritdoc}
   */
  protected $profile = 'standard';

and remove the $modules variable..

And we'll have to remove the line $this->drupalCreateContentType(['type' => 'article']); too as this is provided by standard but the rest of the test works as expected.

@Spokje let's fix this once and do it here or in the other issue. Doing this and changing to use $profile makes no sense.

Wim Leers’s picture

Status: Needs work » Reviewed & tested by the community
Wim Leers’s picture

Title: Replace ckeditor with ckeditor5 in NoJavaScriptAnonymousTest » Update NoJavaScriptAnonymousTest to use Standard profile instead of listing modules
alexpott’s picture

Version: 9.5.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Backported to 9.4.x to keep tests aligned.

  • alexpott committed a73fa30 on 10.1.x
    Issue #3306712 by Spokje, alexpott: Update NoJavaScriptAnonymousTest to...

  • alexpott committed 340ce1a on 10.0.x
    Issue #3306712 by Spokje, alexpott: Update NoJavaScriptAnonymousTest to...

  • alexpott committed 1940fe9 on 9.5.x
    Issue #3306712 by Spokje, alexpott: Update NoJavaScriptAnonymousTest to...

  • alexpott committed 593761b on 9.4.x
    Issue #3306712 by Spokje, alexpott: Update NoJavaScriptAnonymousTest to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.