Problem/Motivation
ckeditor
has been removed from the standard profile and replaced by ckeditor5
in #3271097: Replace CKEditor 4 with CKEditor 5 in the Standard profile and StandardTest.
We forgot to do the same in \Drupal\Tests\system\Functional\Common\NoJavaScriptAnonymousTest
.
Marking this as critical since the parent issue #3270438: Remove CKEditor 4 from core is marked as such.
Steps to reproduce
Proposed resolution
Replace ckeditor with ckeditor5 in \Drupal\Tests\system\Functional\Common\NoJavaScriptAnonymousTest
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3306712
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3306712-replace-ckeditor-with changes, plain diff MR !2701
Comments
Comment #2
SpokjeComment #4
SpokjeBit of a deja vu of #3303453: Remove rdf from \Drupal\Tests\system\Functional\Common\NoJavaScriptAnonymousTest, I've opened #3306713: Refactor module array in NoJavaScriptAnonymousTest to prevent this from becoming a triple vu (or whatever you wanna call it)
Comment #5
SpokjeComment #6
SpokjeComment #7
SpokjeComment #8
quietone CreditAttribution: quietone at PreviousNext commentedThis change is also in the deprecation issue but it makes sense to remove an integration is a separate issue.
Comment #9
SpokjeThanks @quietone, didn't notice it was in the deprecation issue, stumbled upon this whilst doing a test-run of the deletion issue.
Agreed that a separate issue will make it more clear and gives both issues a chance to get to RTBC independently.
Comment #10
Wim LeersRTBC +1
This simplifies #3304326: Deprecate CKEditor 4 module in 9.5 slightly.
Comment #11
alexpottThis test is wrong... I've no idea why we're listing the modules used in standard in this way but it's bound to get out of sync. We should replace the module list and set the $profile property to standard and be done. Maybe this ability wasn't known when #2120457: Add test to guarantee that the Standard profile does not load any JavaScript for anonymous users on critical pages was written and reviewed.
Comment #12
Spokje@alexpott This test _is_ wrong, I've already opened up #3306713: Refactor module array in NoJavaScriptAnonymousTest to
burn it to the groundrefactor it. (See #4, where I also state that this is the second time we/I fallen into this trap).Not sure if we want to refactor the whole test in this issue and postpone ckeditor4/5 on this, personally I don't think so.
But fully agreeing that the test is wrong and needs to be refactored.
Comment #13
alexpottSo we need to add
and remove the $modules variable..
And we'll have to remove the line
$this->drupalCreateContentType(['type' => 'article']);
too as this is provided by standard but the rest of the test works as expected.@Spokje let's fix this once and do it here or in the other issue. Doing this and changing to use $profile makes no sense.
Comment #14
Wim LeersOh, hah, I wrote #2120457: Add test to guarantee that the Standard profile does not load any JavaScript for anonymous users on critical pages almost a decade ago :P
This MR is beautiful clean-up! 🤩
Comment #15
Wim LeersComment #16
alexpottBackported to 9.4.x to keep tests aligned.