Problem/Motivation

In \Drupal\eca\Entity\Eca::validatePlugin we recognize all boolean fields and check if we have to convert back the yes/no dropdown values to boolean at the beginning. Right afterwards, we separately check for replace_tokens fields and see if we have to convert them as well.

However, we've changed all those fields into checkboxes and therefore they are already covered by the first conversion. We can remove that code block completely.

Issue fork eca-3306135

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jurgenhaas created an issue. See original summary.

jurgenhaas’s picture

Status: Active » Needs review
mxh’s picture

I'm not sure about this. If you're certain that this refactor won't change any behavior, go for it.

  • jurgenhaas committed 71c6a35 on 1.1.x
    Issue #3306135: Validate plugin has redundant code for "replace_tokens"...

  • jurgenhaas committed cdc22ed on 1.0.x
    Issue #3306135: Validate plugin has redundant code for "replace_tokens"...
jurgenhaas’s picture

Status: Needs review » Fixed

Yep, I've checked the full codebase, and it's a checkbox consistently.

Committed and back-ported.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.