Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
In \Drupal\eca\Entity\Eca::validatePlugin
we recognize all boolean fields and check if we have to convert back the yes/no dropdown values to boolean at the beginning. Right afterwards, we separately check for replace_tokens
fields and see if we have to convert them as well.
However, we've changed all those fields into checkboxes and therefore they are already covered by the first conversion. We can remove that code block completely.
Issue fork eca-3306135
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
jurgenhaasComment #4
mxhI'm not sure about this. If you're certain that this refactor won't change any behavior, go for it.
Comment #7
jurgenhaasYep, I've checked the full codebase, and it's a checkbox consistently.
Committed and back-ported.