Fix coding standards issues [#3305751]

There are a ton of minor issues identifiable by drupal-check. Fix these so the codebase is happier.

Comment	File	Size	Author
#25	metatag-n3305751-25.patch	24.47 KB	DamienMcKenna
#25	8.x-1.x: PHP 8.1 & MySQL 8, D9.5 379 pass
#25	metatag-n3305751-25.interdiff.txt	6.94 KB	DamienMcKenna
#23	metatag-n3305751-23.patch	18.4 KB	DamienMcKenna
#23	8.x-1.x: PHP 8.1 & MySQL 8, D9.5 362 pass, 6 fail
#23	metatag-n3305751-23.interdiff.txt	5.77 KB	DamienMcKenna
#20	metatag-n3305751-19-src.patch	6.52 KB	DamienMcKenna
#20	8.x-1.x: PHP 8.1 & MySQL 8, D9.5 379 pass
#20	metatag-n3305751-19.interdiff.txt	492 bytes	DamienMcKenna
#16	metatag-n3305751-16-mfiles.patch	13.58 KB	DamienMcKenna
#16	8.x-1.x: PHP 8.1 & MySQL 8, D9.5 379 pass
#16	metatag-n3305751-16-src.patch	6.82 KB	DamienMcKenna
#16	8.x-1.x: PHP 8.1 & MySQL 8, D9.5 378 pass, 1 fail
#13	metatag-n3305751-13.patch	13.48 KB	DamienMcKenna
#13	8.x-1.x: PHP 8.1 & MySQL 8, D9.5 373 pass, 2 fail
#12	metatag-n3305751-12.patch	20.4 KB	DamienMcKenna
#12	8.x-1.x: PHP 8.1 & MySQL 8, D9.5 378 pass, 1 fail
#10	metatag-n3305751-10.patch	33.82 KB	DamienMcKenna
#10	8.x-1.x: PHP 8.1 & MySQL 8, D9.5 372 pass, 3 fail
#10	metatag-n3305751-10.interdiff.txt	679 bytes	DamienMcKenna
#9	metatag-n3305751-8.patch	38.24 KB	DamienMcKenna
#9	8.x-1.x: PHP 8.1 & MySQL 8, D9.5 Patch Failed to Apply
#9	metatag-n3305751-8.interdiff.txt	679 bytes	DamienMcKenna
#8	date-n2898235-39.patch	26.5 KB	DamienMcKenna
#8	8.x-1.x: PHP 8.1 & MySQL 8, D9.5 Patch Failed to Apply
#8	date-n2898235-39.interdiff.txt	1.6 KB	DamienMcKenna
#6	metatag-n3305751-6.patch	33.64 KB	DamienMcKenna
#6	8.x-1.x: PHP 8.1 & MySQL 8, D9.5 370 pass, 3 fail
#5	metatag-n3305751-5.patch	1.91 KB	DamienMcKenna
#5	8.x-1.x: PHP 8.1 & MySQL 8, D9.5 Patch Failed to Apply
#4	metatag-n3305751-4.patch	2.5 KB	DamienMcKenna
#4

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

24 August 2022 at 14:27

DamienMcKenna created an issue. See original summary.

Comment #2

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 24 August 2022 at 14:28

Title:

Fix coding standards issue

» Fix coding standards issues

Comment #3

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 24 August 2022 at 14:28

Comment #4

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 24 August 2022 at 14:39

File	Size
metatag-n3305751-4.patch	2.5 KB

WIP.

Comment #5

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 24 August 2022 at 18:00

Status:

Active

» Needs review

File	Size
metatag-n3305751-5.patch	1.91 KB
8.x-1.x: PHP 8.1 & MySQL 8, D9.5 Patch Failed to Apply

Further WIP, hopefully this doesn't cause regressions.

Comment #6

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 24 August 2022 at 19:16

File	Size
metatag-n3305751-6.patch	33.64 KB
8.x-1.x: PHP 8.1 & MySQL 8, D9.5 370 pass, 3 fail

2 files were hidden/shown/deleted

File	Size
metatag-n3305751-4.patch	2.5 KB

metatag-n3305751-5.patch	1.91 KB
8.x-1.x: PHP 8.1 & MySQL 8, D9.5 Patch Failed to Apply

The correct patch.

Comment #7

24 August 2022 at 19:26

Status:

Needs review

» Needs work

The last submitted patch, 6: metatag-n3305751-6.patch, failed testing. View results

Comment #8

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 9 September 2022 at 18:06

Assigned:	Unassigned	» DamienMcKenna
Status:	Needs work	» Needs review

File	Size
date-n2898235-39.interdiff.txt	1.6 KB
date-n2898235-39.patch	26.5 KB
8.x-1.x: PHP 8.1 & MySQL 8, D9.5 Patch Failed to Apply

Should resolve one of the errors.

Comment #9

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 9 September 2022 at 18:07

File	Size
metatag-n3305751-8.interdiff.txt	679 bytes
metatag-n3305751-8.patch	38.24 KB
8.x-1.x: PHP 8.1 & MySQL 8, D9.5 Patch Failed to Apply

2 files were hidden/shown/deleted

File	Size
date-n2898235-39.interdiff.txt	1.6 KB
date-n2898235-39.patch	26.5 KB
8.x-1.x: PHP 8.1 & MySQL 8, D9.5 Patch Failed to Apply

Those were the wrong patches X-)

Comment #10

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 9 September 2022 at 18:34

File	Size
metatag-n3305751-10.interdiff.txt	679 bytes
metatag-n3305751-10.patch	33.82 KB
8.x-1.x: PHP 8.1 & MySQL 8, D9.5 372 pass, 3 fail

Uh?

Comment #11

9 September 2022 at 18:44

Status:

Needs review

» Needs work

The last submitted patch, 10: metatag-n3305751-10.patch, failed testing. View results

Comment #12

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 23 September 2022 at 20:31

Status:

Needs work

» Needs review

File	Size
metatag-n3305751-12.patch	20.4 KB
8.x-1.x: PHP 8.1 & MySQL 8, D9.5 378 pass, 1 fail

Without the test changes.

Comment #13

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 23 September 2022 at 20:32

File	Size
metatag-n3305751-13.patch	13.48 KB
8.x-1.x: PHP 8.1 & MySQL 8, D9.5 373 pass, 2 fail

Just the test changes.

Comment #14

23 September 2022 at 20:42

The last submitted patch, 12: metatag-n3305751-12.patch, failed testing. View results

Comment #15

23 September 2022 at 20:42

Status:

Needs review

» Needs work

The last submitted patch, 13: metatag-n3305751-13.patch, failed testing. View results

Comment #16

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 23 September 2022 at 21:08

Status:

Needs work

» Needs review

File	Size
metatag-n3305751-16-src.patch	6.82 KB
8.x-1.x: PHP 8.1 & MySQL 8, D9.5 378 pass, 1 fail
metatag-n3305751-16-mfiles.patch	13.58 KB
8.x-1.x: PHP 8.1 & MySQL 8, D9.5 379 pass

Splitting it up even more.

Comment #17

23 September 2022 at 21:20

The last submitted patch, 16: metatag-n3305751-16-src.patch, failed testing. View results

Comment #18

23 September 2022 at 21:31

DamienMcKenna committed a3384c8 on 8.x-1.x

Issue #3305751 by DamienMcKenna: Fix coding standards issues.

Comment #19

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 24 September 2022 at 00:25

Status:

Needs review

» Needs work

I committed metatag-n3305751-16-mfiles.patch.

Now to work on the other changes.

Comment #20

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 26 September 2022 at 18:17

Status:

Needs work

» Needs review

File	Size
metatag-n3305751-19.interdiff.txt	492 bytes
metatag-n3305751-19-src.patch	6.52 KB
8.x-1.x: PHP 8.1 & MySQL 8, D9.5 379 pass

I think I introduced a bug in an earlier patch, this should work.

Comment #21

26 September 2022 at 18:35

DamienMcKenna committed 4369ba4 on 8.x-1.x

Issue #3305751 by DamienMcKenna: Fix coding standards issues.

Comment #22

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 26 September 2022 at 18:36

Status:

Needs review

» Needs work

Committed. Now for the tests.

Comment #23

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 26 September 2022 at 20:39

Status:

Needs work

» Needs review

File	Size
metatag-n3305751-23.interdiff.txt	5.77 KB
metatag-n3305751-23.patch	18.4 KB
8.x-1.x: PHP 8.1 & MySQL 8, D9.5 362 pass, 6 fail

Comment #24

26 September 2022 at 20:50

Status:

Needs review

» Needs work

The last submitted patch, 23: metatag-n3305751-23.patch, failed testing. View results

Comment #25

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 26 September 2022 at 21:21

Status:

Needs work

» Needs review

File	Size
metatag-n3305751-25.interdiff.txt	6.94 KB
metatag-n3305751-25.patch	24.47 KB
8.x-1.x: PHP 8.1 & MySQL 8, D9.5 379 pass

2 files were hidden/shown/deleted

File	Size
metatag-n3305751-23.interdiff.txt	5.77 KB
metatag-n3305751-23.patch	18.4 KB
8.x-1.x: PHP 8.1 & MySQL 8, D9.5 362 pass, 6 fail

Comment #26

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 26 September 2022 at 21:34

Status:

Needs review

» Fixed

Committed.

Comment #27

26 September 2022 at 21:34

DamienMcKenna committed 6490cf4 on 8.x-1.x

Issue #3305751 by DamienMcKenna: Fix coding standards issues.

Comment #28

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 26 September 2022 at 21:35

Status:

Needs review

» Fixed

Comment #29

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 26 September 2022 at 21:35

Assigned:

DamienMcKenna

» Unassigned

Comment #30

10 October 2022 at 21:39

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Fix coding standards issues

Comments

Parent issue

Related issues

Referenced by