Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#10 | 3304901-one-time.patch | 2.6 KB | bnjmnm |
Issue fork drupal-3304901
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
bnjmnmMR runs the fix 800x
Comment #4
xjmComment #5
xjmComment #7
bnjmnmTest iterations are set to 400, can't get much higher without timing out.
Comment #8
xjmQueued a few more, for science, but pending those results I think it's pretty clear the off-canvas fix is applicable to this test and has resolved the fail. So we just need a commit version after that.
Comment #9
longwaveTest fix looks good, we have the trait so we should use it.
NW to remove the DrupalCI changes.
Comment #10
bnjmnmComment #11
xjm👍
Comment #12
tim.plunkettThanks to #3268680: [random test failure] Restore and fix LayoutBuilderDisableInteractionsTest::testFormsLinksDisabled() for providing OffCanvasTestTrait, very nice!
Verifying that this is RTBC.
Comment #17
xjmCommitted to 10.1.x, 10.0.x, 9.5.x, and 9.4.x. Thanks!