Problem/Motivation

A sub task of #3083275: [meta] Update tests that rely on Classy to not rely on it anymore

This issue was originally scoped to removing test dependencies on Classy, as Classy is removed in Drupal 10. These tests were switched to use Starterkit, as that is effectively Classy but works on Drupal 10. Ideally, the test theme should be Stark as nothing in the tests are inherently theme dependent, and Starterkit is more likely to have test-disrupting changes than Stark.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3304382

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bnjmnm created an issue. See original summary.

bnjmnm opened merge request !2637

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm at Acquia commented
Title: Core FunctionalJavascript tests should not depend on Classy » Core Functional tests should not depend on Classy

bnjmnm closed merge request !2637

bnjmnm opened merge request !2641

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm at Acquia commented
Status: Active » Needs review

Use MR 2641 (the only open one)

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work

Could the MR be updated for 10.1 please

Or I can try and open a new MR later this evening

bnjmnm opened merge request !3113

bnjmnm closed merge request !2641

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs work » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

This issue is being reviewed by the kind folks in Slack, #need-reveiw-queue. We are working to keep the size of Needs Review queue [2700+ issues] to around 200, following Review a patch or merge require as a guide.

Thank you for the quick turnaround.

Changes look good to me.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs review

Same question as #3304378-13: Core FunctionalJavascript tests should not depend on Classy or Starterkit I think these two might just be outdated now?

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm at Acquia commented
Title: Core Functional tests should not depend on Classy » Core Functional tests should not depend on Classy or Starterkit
Issue summary: View changes

Updated issue summary with why it is still helpful to make this switch

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Reviewed & tested by the community

Removing credit from myself as I rebased the MR to make sure tests passed. Will let committer decide to add it back or not.

Tests pass and starterkit nor classy are being used so looks good to me.

  • catch committed a9301ea8 on 10.1.x 
    Issue #3304382 by bnjmnm, smustgrave: Core Functional tests should not...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Rebase came with a review, so I think that's OK for credit.

Committed/pushed to 10.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.