Media Library: Clicking "Insert selected" with no media selected triggers fatal error

Is there additional setup or can this be reproduced by installing Drupal?

Please post stack traces as code rather than as an image.

this error also occurred in 9.4.x and 10.0.x

not able to produce the issue.

Testing steps:
1. Created new instance of drupal 9.5.x
2. enable media and media library module
3. configure it in ckeditor basic html /admin/config/content/formats.
4. created new basic page.
5. click on Insert media from library.
6. choose audio tab and inserted one audio.

able to save and see the audio on front end without any error while save and in WD.
performed this same for image too.
Attaching SS for reference.

we need to make some changes on below files.
1.web\core\modules\media_library\src\Plugin\views\field\MediaLibrarySelectForm.php

$selected = array_filter($form_state->getValue($this->options['id']));
    if (empty($selected)) {
      $form_state->setErrorByName('', $this->t('No items selected.'));
    }

to

$selected = array_filter($form_state->getValue($this->options['id']) ?? []);
    if (empty($selected)) {
      $form_state->setErrorByName('', $this->t('No items selected.'));
    }

as we have not selected any item from the list $this->options['id'] is always be null
2. web\core\modules\media_library\src\MediaLibraryEditorOpener.php

public function getSelectionResponse(MediaLibraryState $state, array $selected_ids) {
    $selected_media = $this->mediaStorage->load(reset($selected_ids));

    $response = new AjaxResponse();
    $values = [
      'attributes' => [
        'data-entity-type' => 'media',
        'data-entity-uuid' => $selected_media->uuid(),
        'data-align' => 'center',
      ],
    ];
    $response->addCommand(new EditorDialogSave($values));

    return $response;
  }

to

$selected_media = $this->mediaStorage->load(reset($selected_ids));
    $response = new AjaxResponse();
    if (isset($selected_media)) {
      $values = [
        'attributes' => [
          'data-entity-type' => 'media',
          'data-entity-uuid' => $selected_media->uuid(),
          'data-align' => 'center',
        ],
      ];
      $response->addCommand(new EditorDialogSave($values));
    } else {
      $response->addCommand(new MessageCommand($this->t('No items selected.')));
    }
    return $response;

after applying above changes I am getting below warning in response

( ! ) Warning: array_flip(): Can only flip string and integer values, entry skipped in \drupal-nine\web\core\lib\Drupal\Core\Entity\EntityStorageBase.php on line 312

pointing to this line

$flipped_ids = $ids ? array_flip($ids) : FALSE;

have fixed it by adding array_filter on it as there is no item selected from the list.

$flipped_ids = $ids ? array_flip(array_filter($ids)) : FALSE;

@ aarti zikre I think the steps to reproduce are different. Can you verify?

@ aarti zikre @cilfen
the 6th step is click on Insert selected button without choosing any items.

#11 throwing error on content view page, need to check other way to fix

found the fix.
we need to check the $selected_ids in response;
change in file web\core\modules\media_library\src\MediaLibraryEditorOpener.php would be

public function getSelectionResponse(MediaLibraryState $state, array $selected_ids) {
    $response = new AjaxResponse();
    if (!empty($selected_ids)) {
      $selected_media = $this->mediaStorage->load(reset($selected_ids));
      $values = [
        'attributes' => [
          'data-entity-type' => 'media',
          'data-entity-uuid' => $selected_media->uuid(),
          'data-align' => 'center',
        ],
      ];
      $response->addCommand(new EditorDialogSave($values));
    } else {
      $response->addCommand(new MessageCommand($this->t('No items selected.')));
    }
    return $response;
  }

yes @srijeeta the class will be added in patch. for t() we can use the StringTranslationTrait.

my query is do we need to show the status message or just silently close the dialog box, same as in views where we click on add field button without selecting any fields?

@srijeeta are you creating patch?

another workaround is to check the selected ids on updateWidget() function in web\core\modules\media_library\src\Plugin\views\field\MediaLibrarySelectForm.php.

I have updated code according to #16 & 18 to remove the duplicate status messages and only show once inside the dialog box.

use Drupal\Core\Ajax\RemoveCommand;
use Drupal\Core\Ajax\PrependCommand;

public static function updateWidget(array &$form, FormStateInterface $form_state, Request $request) {
    $field_id = $form_state->getTriggeringElement()['#field_id'];
    $selected_ids = $form_state->getValue($field_id);
    $selected_ids = $selected_ids ? array_filter(explode(',', $selected_ids)) : [];
    if (empty($selected_ids)) {
      $response = new AjaxResponse();
      $messages = ['#type' => 'status_messages'];
      $response->addCommand(new RemoveCommand('#media-library-add-form-wrapper [data-drupal-messages]'));
      $response->addCommand(new PrependCommand('#media-library-add-form-wrapper', \Drupal::service('renderer')->renderRoot($messages)));
      return $response;
    }
    // Allow the opener service to handle the selection.
    $state = MediaLibraryState::fromRequest($request);

    return \Drupal::service('media_library.opener_resolver')
      ->get($state)
      ->getSelectionResponse($state, $selected_ids)
      ->addCommand(new CloseDialogCommand());
  }

Hello, I am having the same problem after the site was upgraded from Drupal Core 9.3.6 to 9.47. When the anonymous user tries to insert a media item in CKeditor, the error ((Call to a member function uuid() on null in Drupal\media_library\MediaLibraryEditorOpener)) occurs.

Thanks @Jaykumar95 for providing the patch #20. I applied the patch on the Drupal core 9.4.7 site. As a result, the error does not occur anymore, and the media still is not inserted into the CKeditor for the anonymous user. The the anonymous user role has the administer media permission.

Drupal environment:
Drupal Core 9.4.x
PHP 8.0

This issue is being reviewed by the kind folks in Slack, #need-reveiw-queue. We are working to keep the size of Needs Review queue [2700+ issues] to around 200, following Review a patch or merge require as a guide.

Attempted to replicate on 10.1 but could not.

Tagging for IS update as there is no proposed solution.

Tagging for tests as bug will need a test case that replicates the issue and causes the error.

Also not sure about the fix has it seems to be fixing a symptom vs root cause.

Still needs a test case.

Typically with these type of issues just putting an isset() or empty() check is masking a deeper issue that should be determined.

I have the same issue.

This is my setup:

• Drupal 10.1.3
• PHP 8.1.14
• MariaDB: 10.4.22-MariaDB-1:10.4.22+maria~focal
• Admin theme is Gin
• CKEditor5

By the way, patch #30 is already included in this Drupal version. And I'm upgrading from CKEditor 4 to CKEditor 5.

I was able to reproduce the issue only with Twig Debug enabled.

Reroll patch for drupal 10.1.7.

Fix missed used statements. Drupal 10.1.7

@ion.macaria - Can you provide interdiff from #30 as it looks same to me.
Also we still need test case for this as mentioned by @smustgrave in #23
Also we need to update the code as suggested in #28 by @smustgrave I agree that using empty() check in this kind situation can cause deeper problems.

patch #34 applies cleanly to Drupal 10.2.3 and fixes the bug.
Needed this after an upgrade from 10.0.11

This seems to relate/overlap with #3340973: Media Library: Argument #1 ($array) must be of type array, null given in array_filter()..
The MR there seems to fix it but I haven't compared the code of both solutions yet.

Hi, I have created the MR, I also added an extra condition in viewsFormValidate that fixed following error(Also added the screenshot).

TypeError: array_filter(): Argument #1 ($array) must be of type array, null given in array_filter() (line 185 of /var/www/html/core/modules/media_library/src/Plugin/views/field/MediaLibrarySelectForm.php).

Test case is still pending, Post observing core/modules/ckeditor5/tests/src/FunctionalJavascript/MediaLibraryTest.php it seems not compatible with Drupal 11 as it still using create blog content permission.

One related issue is https://www.drupal.org/project/drupal/issues/3351597

Thanks
Samit K.

Previously tagged for tests and issue summary both appear still needed.

I ran into this error, but replacing my site config with the default media library view fixed it.

I had changed the view display to use responsive grid.

But that display doesn't support row classes, relating to https://www.drupal.org/project/drupal/issues/2474491

I made a custom display that extends responsive grid to add custom classes back in, and it's working again.

This patch addresses the fatal error "Call to a member function uuid() on null" that occurs when clicking "Insert Selected" in the Media Library without selecting any media items.

Changes

MediaLibrarySelectForm.php
Added early validation in `updateWidget()` to check for empty selection and return a user-friendly error message:

```php
if (empty($selected_ids)) {
$response = new AjaxResponse();
$response->addCommand(new MessageCommand(
(string) \Drupal::translation()->translate('No media items were selected.'),
'#media-library-messages',
['type' => 'error']
));
return $response;
}
```

MediaLibraryEditorOpener.php (NEW - not covered by existing MR)
Added defensive null checks in `getSelectionResponse()` to prevent crashes even if validation is bypassed:

```php
// Return empty response if no media items were selected.
if (empty($selected_ids)) {
return $response;
}

$selected_media = $this->mediaStorage->load(reset($selected_ids));

// Return empty response if the media entity could not be loaded.
if (!$selected_media) {
return $response;
}
```

This defensive fix is important because:
- It prevents crashes if `getSelectionResponse()` is called directly (e.g., by custom code)
- It handles the edge case where a media entity is deleted between selection and submission
- It follows defensive programming best practices

Test Coverage
Added new kernel test `MediaLibraryEditorOpenerTest.php` with three test methods:
- `testGetSelectionResponseWithEmptySelection()` - Verifies empty array doesn't crash
- `testGetSelectionResponseWithInvalidMediaId()` - Verifies non-existent media ID doesn't crash
- `testGetSelectionResponseWithValidSelection()` - Verifies normal operation still works

How to Test Manually

1. Apply the patch
2. Go to any CKEditor field with media embed enabled
3. Click the media button to open Media Library
4. Without selecting any media, click "Insert Selected"
5. **Before patch**: Fatal error
6. **After patch**: Error message "No media items were selected."

Difference from Existing MR (!9413)

The existing MR adds validation in `updateWidget()` but does **not** add defensive checks to `MediaLibraryEditorOpener::getSelectionResponse()`. This patch includes both:

1. Form-level validation (similar to MR approach but simpler)
2. Opener-level defensive checks (not in MR)

The defensive checks in the opener are valuable because they protect against:
- Direct calls to `getSelectionResponse()` that bypass form validation
- Race conditions where media is deleted between selection and submission
- Any future code paths that might call the opener directly

Thanks but tests need to be added to the MR to show it's fixing the problem. patches don't run the test suite. Also issue summary still needs to be updated.

From now on, we have a test in MR 9413.

Issue summary must be better now.

I tested the test with and without the fix.
Namely:

ddev exec ./vendor/bin/phpunit -c core core/modules/media_library/tests/src/FunctionalJavascript/EmbeddedFormWidgetTest
git revert d500fff685089e062f505a3f64b8a20f7ff48111
ddev exec ./vendor/bin/phpunit -c core core/modules/media_library/tests/src/FunctionalJavascript/EmbeddedFormWidgetTest

First one passed
Second one failed.

I did not perform a QA in the code as, from the comments, I see that the tests were missing. RTBC +1.

There are comments in the MR to address.

The title should be description of the change, so adding tag.

Verified the patch is working fine in the Drupal 10.x version. Sharing the verification in local.

Still the Comments need to be addressed.