Let's get this thing ready for D10!

Issue fork lightning_layout-3303347

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

balsama created an issue. See original summary.

balsama opened merge request !3

balsama’s picture

balsama
he/him
Primary language English
Location boston
CreditAttribution: balsama at Acquia commented

I'm not sure how to work around the last failing test. Apparently, there was a `layout_builder_styles.settings` config object at one time that is in the fixture, but doesn't exist anymore.

Setting the `strictConfigSchema` property to FALSE did not work around the issues/had no effect.

We're going to immediately rip these upgrade paths out after creating a new branch. Any objections to merging this as-is?

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Active » Reviewed & tested by the community

I'm fine with that. RTBC when tests (except for UpdatePathTest, if it fails) pass.

  • balsama committed b8f5a3c on 8.x-2.x 
    Issue #3303347: Make ready for D10
balsama’s picture

balsama
he/him
Primary language English
Location boston
CreditAttribution: balsama at Acquia commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.