Problem/Motivation

Now that we've opened the 6.0.x branch of Lightning Core, let's drop support for as much old stuff as possible:

Drupal 9.2 and older
PHP 7.2 and older
All update paths
All deprecated code
Any deprecated dependencies

Issue fork lightning_core-3303325

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima created an issue. See original summary.

phenaproxima opened merge request !2

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented

A few notes on what I'm doing here:

  • I'm removing all the dynamic changelog generation, and materials needed for that. It's a relic of our old GitHub-based release process, and with the Lightning distribution buried, it's not needed.
  • All info files drop support for Drupal older than 9.3.
  • The main composer.json no longer defines a dependency on drupal/core. I'll let packages.drupal.org derive that information from the info files.
  • FormHelper is a deprecated service, so it's gone.
  • Anything Behat-related is removed.
  • All existing update paths are dropped, along with their test coverage and fixtures.
  • Drush 9 support is dropped.
  • The composer.lock and install-drupal.sh files are deleted. They're artifacts from when we had this module contain its own dev environment. Going forward, just clone this module into an existing core checkout or project.
  • Drupal Console support is dropped.
balsama’s picture

balsama
he/him
Primary language English
Location boston
CreditAttribution: balsama at Acquia commented
  • I'm removing all the dynamic changelog generation, and materials needed for that. It's a relic of our old GitHub-based release process, and with the Lightning distribution buried, it's not needed.
    This one almost seems like busywork. But I agree we don't _need_ it anymore.
  • All info files drop support for Drupal older than 9.3.
    +1
  • The main composer.json no longer defines a dependency on drupal/core. I'll let packages.drupal.org derive that information from the info files.
    +1
  • FormHelper is a deprecated service, so it's gone.
    +1
  • Anything Behat-related is removed.
    I seem to remember a recent issue about ripping this out. I guess we didn't do that already? Do you happen to know what issue I'm thinking of and can you link it?
  • All existing update paths are dropped, along with their test coverage and fixtures.
    +1
  • Drush 9 support is dropped.
    +1
  • The composer.lock and install-drupal.sh files are deleted. They're artifacts from when we had this module contain its own dev environment. Going forward, just clone this module into an existing core checkout or project.
    +1
  • Drupal Console support is dropped.
    +1
balsama’s picture

balsama
he/him
Primary language English
Location boston
CreditAttribution: balsama at Acquia commented

@phenaproxima pointed me to https://www.drupal.org/project/lightning_core/issues/3293692

If that's to be resolved (which I'm not sure it will) - it will have to happen in the 5.x version. I'm +1 for "Anything Behat-related is removed."

  • phenaproxima committed 18f6681 on 6.0.x 
    Issue #3303325 by phenaproxima: Drop support for old stuff
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Active » Fixed

Whew; I just felt the world get lighter. Merged into 6.0.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.